Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKS: Add ephemeral disk volume type and nvme perf tier support to Azure Container Storage #7730

Merged
merged 17 commits into from
Jun 26, 2024
Merged

AKS: Add ephemeral disk volume type and nvme perf tier support to Azure Container Storage #7730

merged 17 commits into from
Jun 26, 2024

Conversation

mukhoakash
Copy link
Contributor

This PR adds support to change the ephemeral disk volume type ephemeral nvme perf tier for Azure Container Storage installations on AKS cluster.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 19, 2024 •
edited
Loading

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter ephemeral_disk_nvme_perf_tier
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter ephemeral_disk_volume_type
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter ephemeral_disk_nvme_perf_tier
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter ephemeral_disk_volume_type

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 19, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions GitHub Actions
Copy link

For more info about extension versioning, please refer to Extension version schema

FumingZhang
FumingZhang reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some live test cases for the newly added options?

src/aks-preview/HISTORY.rst Outdated
@@ -13,12 +13,18 @@ Pending
+++++++
* Vendor new SDK and bump API version to 2024-04-02-preview.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this note as part of 5.0.0b2 as well

@mukhoakash mukhoakash force-pushed the mukhoakash/new_acstor_cli branch 3 times, most recently from e45106f to f418fd7 Compare June 23, 2024 08:03
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 23, 2024

Please fix CI issues

@mukhoakash mukhoakash force-pushed the mukhoakash/new_acstor_cli branch 3 times, most recently from eed6e7f to f4ce0fa Compare June 25, 2024 06:10
@FumingZhang
Copy link
Member

I've fixed the common style/lint issue in aks-preview via another PR #7741, please rebase from main.

@mukhoakash
Copy link
Contributor Author

mukhoakash commented Jun 25, 2024 •
edited
Loading

Triggered live test:

  • test_aks_create_with_azurecontainerstorage
  • test_aks_update_with_azurecontainerstorage
  • test_aks_create_with_azurecontainerstorage_with_nodepool_name
  • test_aks_create_with_azurecontainerstorage_with_ephemeral_disk_parameters

@mukhoakash
Copy link
Contributor Author

Triggered new live test:

test_aks_create_with_azurecontainerstorage
test_aks_update_with_azurecontainerstorage
test_aks_create_with_azurecontainerstorage_with_nodepool_name
test_aks_create_with_azurecontainerstorage_with_ephemeral_disk_parameters

FumingZhang
FumingZhang approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanzhudd yanzhudd merged commit fcbc0ae into Azure:main Jun 26, 2024
18 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167719&view=results

@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167768&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
@mukhoakash @t-lstauber
AKS: Add ephemeral disk volume type and nvme perf tier support to Azu…
571a084 
…re Container Storage (Azure#7730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FumingZhang FumingZhang FumingZhang approved these changes

@yanzhudd yanzhudd yanzhudd approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@zhoxing-ms zhoxing-ms

@yanzhudd yanzhudd

Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Milestone
June 2024 (2024-07-09)
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mukhoakash @yonzhan @FumingZhang @azclibot @yanzhudd @zhoxing-ms