[AKS] Add mutable fips cli flags (enable/disable on nodepool update) #7752
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks nodepool update | cmd aks nodepool update added parameter disable_fips_image |
||
| aks nodepool update | cmd aks nodepool update added parameter enable_fips_image |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
For more info about extension versioning, please refer to Extension version schema |
github-actions
bot
added
the
release-version-block
pineapplethevoyager
changed the title
github-actions
bot
removed
the
release-version-block
pineapplethevoyager
requested review from
andyliuliming and
FumingZhang
as code owners
There was a problem hiding this comment.
Looks good to me, but seems you accidentally touched the recording file test_aks_skip_gpu_driver_install.yaml and failed the CI, please reset the change on that file
Queued live test to validate the change, test passed!
- test_aks_create_update_fips_flow
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=168476&view=results |
| self.check("agentPoolProfiles[0].enableFips", True), | ||
| ], | ||
| ) | ||
|
|
There was a problem hiding this comment.
add an update without either --enable-fips-image or --disable-fips-image, EnableFips should not change.
| self.check("enableFips", False), | ||
| ], | ||
| ) | ||
|
|
There was a problem hiding this comment.
add an update without either --enable-fips-image or --disable-fips-image, EnableFips should not change.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.