Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading mdp extension to latest version and supporting new commands #7760

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

ajaykn
Copy link
Contributor

@ajaykn ajaykn commented Jul 1, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Command: az mdp

We have latest version of mdp "Microsoft.DevOpsInfrastructure" Resource provider api to 2024-04-04-preview

https://github.com/Azure/azure-rest-api-specs/tree/main/specification/devopsinfrastructure/resource-manager/Microsoft.DevOpsInfrastructure/preview/2024-04-04-preview

As part of this PR, we upgrade the commands to latest version and support the new commands
New commands are

  • az mdp sku list
  • az mdp usage list
  • az mdp pool agent list

Related PR in aaz models: Azure/aaz#511

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 1, 2024

❌Azure CLI Extensions Breaking Change Test
❌mdp
rule cmd_name rule_message suggest_message
1007 - ParaRemove mdp pool create cmd mdp pool create removed parameter provisioning_state please add back parameter provisioning_state for cmd mdp pool create
⚠️ 1011 - SubgroupAdd mdp pool agent sub group mdp pool agent added
⚠️ 1010 - ParaPropUpdate mdp pool create cmd mdp pool create update parameter dev_center_project_resource_id: updated property name from dev_center_project_resource_id to devcenter_project_resource_id
⚠️ 1006 - ParaAdd mdp pool update cmd mdp pool update added parameter agent_profile
⚠️ 1006 - ParaAdd mdp pool update cmd mdp pool update added parameter devcenter_project_resource_id
⚠️ 1006 - ParaAdd mdp pool update cmd mdp pool update added parameter fabric_profile
⚠️ 1006 - ParaAdd mdp pool update cmd mdp pool update added parameter maximum_concurrency
⚠️ 1006 - ParaAdd mdp pool update cmd mdp pool update added parameter organization_profile
⚠️ 1011 - SubgroupAdd mdp sku sub group mdp sku added
⚠️ 1011 - SubgroupAdd mdp usage sub group mdp usage added

Copy link

Hi @ajaykn,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 1, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jul 1, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jul 1, 2024

For more info about extension versioning, please refer to Extension version schema

@ajaykn ajaykn marked this pull request as ready for review July 1, 2024 06:51
@ajaykn
Copy link
Contributor Author

ajaykn commented Jul 1, 2024

❌Azure CLI Extensions Breaking Change Test

❌mdp

1007 - ParaRemove
mdp pool create
cmd mdp pool create removed parameter provisioning_state
please add back parameter provisioning_state for cmd mdp pool create

This is fine, since it was a bug in older version. we dont support this parameter in creation flow.

@kairu-ms kairu-ms merged commit 45fe341 into Azure:main Jul 4, 2024
18 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 4, 2024

[Release] Update index.json for extension [ mdp ] : https://dev.azure.com/azclitools/release/_build/results?buildId=169845&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants