Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSH] Remove CTYPES dependency #7765

Merged
merged 4 commits into from
Jul 19, 2024
Merged

[SSH] Remove CTYPES dependency #7765

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
318a9fb
Start RDP process using subprocess library instead of _process_helper
vthiebaut10 Jul 1, 2024
33975be
Update version and history
vthiebaut10 Jul 1, 2024
fabb502
Use communicate() instead of wait() to wait for the RDP process to ex…
vthiebaut10 Jul 11, 2024
b59bff6
Fix style
vthiebaut10 Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/ssh/HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
Release History
===============
2.0.5
-----
* Remove ctypes dependency from RDP feature

2.0.4
-----
* Install Arc SSH Proxy from MAR
Expand Down
113 changes: 0 additions & 113 deletions src/ssh/azext_ssh/_process_helper.py
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/ssh/azext_ssh/rdp_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ def start_rdp_connection(ssh_info, delete_keys, delete_cert):


def call_rdp(local_port):
from . import _process_helper
if platform.system() == 'Windows':
print_styled_text((Style.SUCCESS, "Launching Remote Desktop Connection"))
print_styled_text((Style.IMPORTANT, "To close this session, close the Remote Desktop Connection window."))
command = [_get_rdp_path(), f"/v:localhost:{local_port}"]
_process_helper.launch_and_wait(command)
process = subprocess.Popen(command)
process.wait()


def is_local_port_open(local_port):
Expand Down
2 changes: 1 addition & 1 deletion src/ssh/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from setuptools import setup, find_packages

VERSION = "2.0.4"
VERSION = "2.0.5"

CLASSIFIERS = [
'Development Status :: 4 - Beta',
Expand Down
Loading