Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature accessrule servicetag changes #7769

Merged

Conversation

bhupeshbhatt1985
Copy link
Contributor

@bhupeshbhatt1985 bhupeshbhatt1985 commented Jul 2, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 2, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @bhupeshbhatt1985,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @bhupeshbhatt1985,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 2, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jul 2, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@yonzhan yonzhan requested a review from kairu-ms July 2, 2024 07:41
Copy link

github-actions bot commented Jul 2, 2024

⚠️ Release Suggestions

Module: nsp

  • ⚠️ Please update VERSION to be 1.0.0b1 in src/nsp/setup.py
  • ⚠️ Remove azext.isExperimental: true in azext_nsp/azext_metadata.json

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

src/nsp/setup.py Outdated Show resolved Hide resolved
@bhupeshbhatt1985
Copy link
Contributor Author

@kaushal087 please review this. please dont release it until reviewed by Kaushal

@kaushal087
Copy link
Contributor

@bhupeshbhatt1985 Looks good to me.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 3, 2024

Please fix CI issues

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jul 4, 2024
@kairu-ms kairu-ms merged commit a9c64b3 into Azure:main Jul 4, 2024
18 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 4, 2024

[Release] Update index.json for extension [ nsp ] : https://dev.azure.com/azclitools/release/_build/results?buildId=169923&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-block Updates do not qualify release version rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants