Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fleet] upgrade fleet sdk to 2024-05-02-preview #7772

Closed
wants to merge 3 commits into from
Closed

Conversation

pdaru
Copy link
Member

@pdaru pdaru commented Jul 2, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 2, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @pdaru,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @pdaru,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 2, 2024

fleet

Copy link

github-actions bot commented Jul 2, 2024

⚠️ Release Suggestions

Module: fleet

  • ⚠️ Please update VERSION to be 1.1.3 in src/fleet/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jul 2, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules label Jul 2, 2024
@pdaru
Copy link
Member Author

pdaru commented Jul 2, 2024

I'm not sure how/why it made changes to amg dir. Individual commits suggest no changes to those files.

@pdaru
Copy link
Member Author

pdaru commented Jul 2, 2024

$ azdev style fleet

===============
| Style Check |

extension(s): [ fleet ] installed from a wheel may need --include-whl-extensions option

unsure how to resolve this.

@kairu-ms please could you help resolve the 2 issues?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you changed the amg folder?

@kairu-ms kairu-ms requested a review from AllyW July 4, 2024 05:03
@kairu-ms
Copy link
Contributor

kairu-ms commented Jul 4, 2024

I'm not sure how/why it made changes to amg dir. Individual commits suggest no changes to those files.

You can revert back the change in amg folder

@kairu-ms
Copy link
Contributor

kairu-ms commented Jul 4, 2024

$ azdev style fleet

===============

| Style Check |
extension(s): [ fleet ] installed from a wheel may need --include-whl-extensions option

unsure how to resolve this.

@kairu-ms please could you help resolve the 2 issues?

You should install it from source code instead of wheel. Please uninstall it by az extension remove --name fleet first. Then use azdev extension add fleet to install from your source code.

@pdaru pdaru closed this by deleting the head repository Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants