Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save & Commit commands #7780

Closed
wants to merge 19 commits into from

Conversation

liorstauber
Copy link
Contributor

@liorstauber liorstauber commented Jul 8, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Added firewall policy Save&Commit commands:
az network firewall policy draft create
az network firewall policy draft update
az network firewall policy draft intrusion-detection add
az network firewall policy draft intrusion-detection remove
az network firewall policy draft intrusion-detection list
az network firewall policy rule-collection-group draft
az network firewall policy rule-collection-group draft create
az network firewall policy rule-collection-group draft update
az network firewall policy rule-collection-group draft collection add-nat-collection
az network firewall policy rule-collection-group draft collection add-filter-collection
az network firewall policy rule-collection-group draft collection remove
az network firewall policy rule-collection-group draft collection rule add
az network firewall policy rule-collection-group draft collection rule update
az network firewall policy rule-collection-group draft collection rule remove

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 8, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️azure-firewall
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd network firewall policy deploy cmd network firewall policy deploy added
⚠️ 1011 - SubgroupAdd network firewall policy draft sub group network firewall policy draft added
⚠️ 1011 - SubgroupAdd network firewall policy rule-collection-group draft sub group network firewall policy rule-collection-group draft added

Copy link

Hi @liorstauber,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 8, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jul 8, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jul 8, 2024

For more info about extension versioning, please refer to Extension version schema

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jul 8, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules label Jul 9, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 14, 2024

Please fix CI issues

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jul 14, 2024
@liorstauber liorstauber force-pushed the liorstauber/save_and_commit branch 2 times, most recently from d5ff69c to 51529dd Compare July 14, 2024 18:36
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules label Jul 14, 2024
@liorstauber liorstauber marked this pull request as ready for review July 17, 2024 13:02
@liorstauber
Copy link
Contributor Author

Please fix CI issues

fixed, can you help merging?

@@ -8,7 +8,7 @@
from codecs import open
from setuptools import setup, find_packages

VERSION = "1.0.1"
VERSION = "1.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mismatched in HISTORY.rst

@necusjz
Copy link
Member

necusjz commented Jul 22, 2024

could you please provide your pr in the aaz repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants