Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informatica generated commands - stable swagger version 2024-05-08 #7783

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

almasak
Copy link
Member

@almasak almasak commented Jul 9, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

Copy link

Hi @almasak,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 9, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jul 9, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jul 9, 2024

For more info about extension versioning, please refer to Extension version schema

Comment on lines 4 to 5
## How to use ##
Please add commands usage here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add content in this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added

Comment on lines 18 to 19
"""Create a InformaticaOrganizationResource
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add examples for commands in aaz-dev-tools before release, you can following this doc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!



@register_command(
"informatica data-management organization serverless-runtime serverless resource-by-id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this command and the informatica data-management organization serverless-runtime show command

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Currently, they are doing the same thing. I have removed informatica data-management organization serverless-runtime show command for now.



@register_command(
"informatica data-management organization serverless-runtime serverless resource-by-id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the informatica data-management organization serverless-runtime show command? If they do the same thing, I recommend you keep the informatica data-management organization serverless-runtime show command. But if you prefer this command, I recommend rename it by the following one as it didn't use any id argument when using this command.

Suggested change
"informatica data-management organization serverless-runtime serverless resource-by-id",
"informatica data-management organization serverless-runtime serverless show-resource",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! I would fix that when I add the serverless commands in the next iteration

@kairu-ms kairu-ms merged commit 9b2b0f0 into Azure:main Jul 11, 2024
18 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ informatica ] : https://dev.azure.com/azclitools/release/_build/results?buildId=171636&view=results

liorstauber pushed a commit to liorstauber/azure-cli-extensions that referenced this pull request Jul 14, 2024
…zure#7783)

* Informatica generated commands - stable swagger version 2024-05-08

* Shortened arguement names

* Revert shortened arguement for resource group

* Informatica tests and records

* Add examples to generated commands

* Removed informatica data-management organization serverless-runtime show

* Add Integ test

* Remove serverless commands and add README

* test fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants