-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Informatica generated commands - stable swagger version 2024-05-08 #7783
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @almasak, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
For more info about extension versioning, please refer to Extension version schema |
src/informatica/README.md
Outdated
## How to use ## | ||
Please add commands usage here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add content in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added
"""Create a InformaticaOrganizationResource | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add examples for commands in aaz-dev-tools before release, you can following this doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
|
||
|
||
@register_command( | ||
"informatica data-management organization serverless-runtime serverless resource-by-id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between this command and the informatica data-management organization serverless-runtime show
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Currently, they are doing the same thing. I have removed informatica data-management organization serverless-runtime show command for now.
|
||
|
||
@register_command( | ||
"informatica data-management organization serverless-runtime serverless resource-by-id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the informatica data-management organization serverless-runtime show
command? If they do the same thing, I recommend you keep the informatica data-management organization serverless-runtime show
command. But if you prefer this command, I recommend rename it by the following one as it didn't use any id argument when using this command.
"informatica data-management organization serverless-runtime serverless resource-by-id", | |
"informatica data-management organization serverless-runtime serverless show-resource", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! I would fix that when I add the serverless commands in the next iteration
[Release] Update index.json for extension [ informatica ] : https://dev.azure.com/azclitools/release/_build/results?buildId=171636&view=results |
…zure#7783) * Informatica generated commands - stable swagger version 2024-05-08 * Shortened arguement names * Revert shortened arguement for resource group * Informatica tests and records * Add examples to generated commands * Removed informatica data-management organization serverless-runtime show * Add Integ test * Remove serverless commands and add README * test fixes
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.