Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public preview wif changes #7785

Merged
merged 26 commits into from
Jul 23, 2024
Merged

Conversation

deeksha345
Copy link
Contributor

@deeksha345 deeksha345 commented Jul 9, 2024


This PR is to make the relevant changes for the Workload Identity feature going public preview.
As part of this feature, we are updating the connectedk8s cli extension and adding the following flags:
--enable-oidc-issuer
--enable-workload-identity

The flags are being added to the az connectedk8s connect and update commands.

I am updating the request payload that is being sent to Connected Cluster RP (KC RP) with the workload identity fields if present.
For the update_connected_cluster custom logic I am adding a pattern of getting the current connected cluster resource, generating a request payload with additional properties if present and then doing a PUT on KC RP with the update resource model.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 9, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️connectedk8s
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd connectedk8s connect cmd connectedk8s connect added parameter enable_oidc_issuer
⚠️ 1006 - ParaAdd connectedk8s connect cmd connectedk8s connect added parameter enable_workload_identity
⚠️ 1006 - ParaAdd connectedk8s connect cmd connectedk8s connect added parameter self_hosted_issuer
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter disable_workload_identity
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter enable_oidc_issuer
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter enable_workload_identity
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter self_hosted_issuer

Copy link

Hi @deeksha345,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 9, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jul 9, 2024

For more info about extension versioning, please refer to Extension version schema

@yonzhan yonzhan removed the request for review from kairu-ms July 9, 2024 23:15
@deeksha345 deeksha345 marked this pull request as draft July 10, 2024 17:28
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules label Jul 10, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Jul 10, 2024

Please fix CI issues

src/connectedk8s/azext_connectedk8s/custom.py Outdated Show resolved Hide resolved
src/connectedk8s/azext_connectedk8s/_utils.py Outdated Show resolved Hide resolved
src/connectedk8s/HISTORY.rst Outdated Show resolved Hide resolved
@deeksha345 deeksha345 marked this pull request as ready for review July 11, 2024 18:46
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules label Jul 11, 2024
@deeksha345
Copy link
Contributor Author

deeksha345 commented Jul 15, 2024

@zhoxing-ms @yonzhan - Can you guys please review this PR and let me know if there are any updates needed to unblock merging of this PR

@yanzhudd
Copy link
Contributor

please fix the linter issue

@yanzhudd
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit bd83635 into Azure:main Jul 23, 2024
17 of 18 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=174826&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants