-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public preview wif changes #7785
Conversation
…cPreviewWifChanges
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
connectedk8s connect | cmd connectedk8s connect added parameter enable_oidc_issuer |
||
connectedk8s connect | cmd connectedk8s connect added parameter enable_workload_identity |
||
connectedk8s connect | cmd connectedk8s connect added parameter self_hosted_issuer |
||
connectedk8s update | cmd connectedk8s update added parameter disable_workload_identity |
||
connectedk8s update | cmd connectedk8s update added parameter enable_oidc_issuer |
||
connectedk8s update | cmd connectedk8s update added parameter enable_workload_identity |
||
connectedk8s update | cmd connectedk8s update added parameter self_hosted_issuer |
Hi @deeksha345, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
For more info about extension versioning, please refer to Extension version schema |
Please fix CI issues |
@zhoxing-ms @yonzhan - Can you guys please review this PR and let me know if there are any updates needed to unblock merging of this PR |
… workload identity properties also
please fix the linter issue |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=174826&view=results |
This PR is to make the relevant changes for the Workload Identity feature going public preview.
As part of this feature, we are updating the connectedk8s cli extension and adding the following flags:
--enable-oidc-issuer
--enable-workload-identity
The flags are being added to the az connectedk8s connect and update commands.
I am updating the request payload that is being sent to Connected Cluster RP (KC RP) with the workload identity fields if present.
For the update_connected_cluster custom logic I am adding a pattern of getting the current connected cluster resource, generating a request payload with additional properties if present and then doing a PUT on KC RP with the update resource model.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.