[AKS]: Remove support for az aks mesh egress gateway commands
#7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌Azure CLI Extensions Breaking Change Test
|
|
AKS |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
yonzhan
|
FumingZhang
reviewed
Jul 12, 2024
FumingZhang
reviewed
Jul 12, 2024
FumingZhang
reviewed
Jul 12, 2024
FumingZhang
reviewed
Jul 12, 2024
| @@ -396,23 +396,12 @@ def load_command_table(self, _): | |||
| "aks_mesh_enable_ingress_gateway", | |||
| supports_no_wait=True, | |||
| ) | |||
| g.custom_command( | |||
| "enable-egress-gateway", | |||
| "aks_mesh_enable_egress_gateway", | |||
There was a problem hiding this comment.
Oh, I think you should also delete the command implementations, like function aks_mesh_disable_egress_gateway in custom.py
There was a problem hiding this comment.
Would like to keep this if possible as we will likely reintroduce egress gateway in the near future.
There was a problem hiding this comment.
I agree with Niranjan here, we would like to keep it as we see that egress gateway functionality will be reintroduced. This PR is to just remove user/test facing code components. @FumingZhang let us know your thoughts?
nshankar13
approved these changes
Jul 12, 2024
SanyaKochhar
approved these changes
Jul 12, 2024
FumingZhang
approved these changes
Jul 15, 2024
yanzhudd
approved these changes
Jul 15, 2024
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=172360&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks mesh enable-egress-gateway -n cluster-name -g rg-nameaz aks mesh disable-egress-gateway -n cluster-name -g rg-nameGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.