Upgrade ArcK8sDiagnoser and fix Style, Linter issues #7810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌Azure CLI Extensions Breaking Change Test
|
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
jsntcy,
yonzhan and
yanzhudd
microsoft-github-policy-service
bot
added
Connected Kubernetes
Auto-Assign
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
9lash
approved these changes
Jul 18, 2024
|
Please fix CI issues |
The azdev setup task is failing in all these jobs - it is happening across PRs. Can you pl. investigate and fix this? |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7810 in repo Azure/azure-cli-extensions |
|
github-actions
bot
added
the
release-version-block
|
@bebound , can you please review the PR, and help merge the changes? |
AllyW
reviewed
Jul 23, 2024
|
please resolve code conflicts |
yanzhudd
reviewed
Jul 23, 2024
|
Hi folks, I have addressed the comments. Can you please take another look? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
yanzhudd
approved these changes
Jul 30, 2024
yanzhudd
removed
the
release-version-block
|
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177061&view=results |
|
Thanks a lot for your help with merging this, @yanzhudd - really appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedk8s
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.