-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm repair bitlocker key #7815
base: main
Are you sure you want to change the base?
vm repair bitlocker key #7815
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
vm repair create | cmd vm repair create added parameter encrypted_vm_recovery_password |
Hi @corsini-msft, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
# Unlocks the disk using the phasephrase and mounts it on the repair VM. | ||
WINDOWS_RUN_SCRIPT_NAME = 'win-mount-encrypted-disk.ps1' | ||
return _invoke_run_command(WINDOWS_RUN_SCRIPT_NAME, repair_vm_name, repair_group_name, False) | ||
BITLOCKER_RECOVERY_PARAMS = None | ||
if encrypted_vm_recovery_password is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps "if encrypted_vm_recovery_password is not None:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest.
@@ -29,7 +32,8 @@ if ($bekFile) | |||
$bekFilePath = $bekFile.FullName | |||
Write-Output "Found $bekFilePath" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain me this logic bit? What if there is no bek file and there is no bit locker key. Else is removed.
Also when bitlocker key is set then this should be null $bekPartition.DriveLetter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is largely fixed in latest push. Added elseif statements for when bitlockerkey is provided, and moved the logic to fetch the bek file into an early if block before the unlock-bitlocker cmd.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.