Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Firewall Policy application rule new parameter - HTTP Headers to insert #7816

Merged
merged 19 commits into from
Aug 6, 2024

Conversation

NiviShenker
Copy link
Contributor

@NiviShenker NiviShenker commented Jul 22, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • network firewall policy rule-collection-group collection rule add/update: new parameter --http-headers-to-insert

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

aaz PR: Azure/aaz#533

Copy link

azure-client-tools-bot-prd bot commented Jul 22, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️azure-firewall
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network firewall policy rule-collection-group collection add-filter-collection cmd network firewall policy rule-collection-group collection add-filter-collection added parameter http_headers_to_insert
⚠️ 1006 - ParaAdd network firewall policy rule-collection-group collection rule add cmd network firewall policy rule-collection-group collection rule add added parameter http_headers_to_insert
⚠️ 1006 - ParaAdd network firewall policy rule-collection-group collection rule update cmd network firewall policy rule-collection-group collection rule update added parameter http_headers_to_insert

Copy link

Hi @NiviShenker,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 22, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jul 22, 2024

For more info about extension versioning, please refer to Extension version schema

@NiviShenker NiviShenker marked this pull request as ready for review July 29, 2024 13:03
@necusjz
Copy link
Member

necusjz commented Jul 31, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Aug 5, 2024

Hi @NiviShenker, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

setup.py needs to be updated

@necusjz necusjz merged commit 0058d5e into Azure:main Aug 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants