[vm-repair] Fix public IP resource name; Add option to skip public IP creation #7820
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm repair create | cmd vm repair create added parameter no |
|
vm-repair |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms,
yanzhudd and
qwuae1
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution GISGuy! We will review the pull request and get back to you soon. |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
github-actions
bot
added
the
release-version-block
| @@ -33,6 +33,7 @@ def load_arguments(self, _): | |||
| c.argument('associate_public_ip', help='Option to create repair vm with public ip') | |||
| c.argument('distro', help='Option to create repair vm from a specific linux distro (rhel7|rhel8|suse12|ubuntu20|centos7|oracle7)') | |||
| c.argument('yes', help='Option to skip prompt for associating public ip and confirm yes to it in no Tty mode') | |||
| c.argument('no', help='Option to skip prompt for associating public ip and confirm no to it in no Tty mode') | |||
There was a problem hiding this comment.
Instead of yes and no as separate options. Is it good to add one command as public ip address yes or no?
There was a problem hiding this comment.
I dont know if we have to maintain the backward compatibility of passing yes.
There was a problem hiding this comment.
I personally don't like the parameter name --yes or --no, and I agree with you that using a new parameter like createPublicIp makes more sense. However, for the sake of backward compatibility, I think it's better to use --no in this situation.
There was a problem hiding this comment.
+1. We cannot break backward compat. I also don't like --yes, --no. Another option could be to introduce a new param and have it enable yes and no. That way, users can use the new param to specify yes/no and the old value van remain with yes support only. We can update documentation to remove --yes over time.
| @@ -33,6 +33,7 @@ def load_arguments(self, _): | |||
| c.argument('associate_public_ip', help='Option to create repair vm with public ip') | |||
| c.argument('distro', help='Option to create repair vm from a specific linux distro (rhel7|rhel8|suse12|ubuntu20|centos7|oracle7)') | |||
| c.argument('yes', help='Option to skip prompt for associating public ip and confirm yes to it in no Tty mode') | |||
| c.argument('no', help='Option to skip prompt for associating public ip and confirm no to it in no Tty mode') | |||
There was a problem hiding this comment.
+1. We cannot break backward compat. I also don't like --yes, --no. Another option could be to introduce a new param and have it enable yes and no. That way, users can use the new param to specify yes/no and the old value van remain with yes support only. We can update documentation to remove --yes over time.
| @@ -1,6 +1,11 @@ | |||
|
|
|||
| Release History | |||
| =============== | |||
| 1.0.8 | |||
| ++++++ | |||
| Add option `--no` to skip public IP creation during `az vm repair create` command. | |||
There was a problem hiding this comment.
This feature is not in the critical path as we don't have many asks for it. So, we could wait this out till after the CrowdStrike usage dips.
There was a problem hiding this comment.
CrowdStrick fix script is pretty stable as of now. Do you think we should merge this change now?
I tried the unit test on the main branch and it doesn't work at all. Based on that, I can barely add new unit tests. |
When the extension prompts the user for public IP creation, if the user chooses
y, it currently creates a public IP with the nameFalse.After the fix, it will create the public IP resource using the default naming convention.
--noto skip public IP creationWhen the user adds
--noto the command parameter, the extension will skip prompting the user for the public IP creation and bypass the creation process.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.