-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cli to support arc gateway and workload identity #7822
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
connectedk8s connect | cmd connectedk8s connect added parameter configuration_protected_settings |
||
connectedk8s connect | cmd connectedk8s connect added parameter configuration_settings |
||
connectedk8s connect | cmd connectedk8s connect added parameter gateway_resource_id |
||
connectedk8s update | cmd connectedk8s update added parameter configuration_protected_settings |
||
connectedk8s update | cmd connectedk8s update added parameter configuration_settings |
||
connectedk8s update | cmd connectedk8s update added parameter disable_gateway |
||
connectedk8s update | cmd connectedk8s update added parameter gateway_resource_id |
Hi @bavneetsingh16, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
missing imports, undefined variables
…16/azure-cli-extensions into feature/arc_gateway
…16/azure-cli-extensions into feature/arc_gateway
…hecks Relax RP registration checks
…16/azure-cli-extensions into feature/arc_gateway
Please fix CI issues |
@yanzhudd Could you please help review this PR when you have time? |
src/connectedk8s/HISTORY.rst
Outdated
@@ -3,6 +3,13 @@ | |||
Release History | |||
=============== | |||
|
|||
1.10.0 | |||
++++++ | |||
* Added support for arc gateway feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Added support for arc gateway feature. | |
* Add support for arc gateway feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is better to specify which commands/parameters are impacted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thanks for reviewing!
please note Azure CLI team is only responsible for code style and specification but not business logic, so it is better to involve service team to review this PR as well. |
please let me confirm with you if there are no tests added in this PR for the changes. If so, please add tests to verify if the changes meet your expectation. |
@yanzhudd, Deeksha and I are members of the service team owning this CLI extension. I have made the necessary updates, and we have thoroughly reviewed and extensively tested them, including a bug bash session. Additionally, we utilized the custom .whl file for this version within our testing framework, which allows us to test across all regions, providing greater confidence. This testing covered all scenarios for the CLI extension and the newly introduced gateway changes. Could you please review the changes again and merge if everything looks good? |
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=195845&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.