Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cli to support arc gateway and workload identity #7822

Merged
merged 74 commits into from
Oct 10, 2024

Conversation

bavneetsingh16
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 23, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️connectedk8s
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd connectedk8s connect cmd connectedk8s connect added parameter configuration_protected_settings
⚠️ 1006 - ParaAdd connectedk8s connect cmd connectedk8s connect added parameter configuration_settings
⚠️ 1006 - ParaAdd connectedk8s connect cmd connectedk8s connect added parameter gateway_resource_id
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter configuration_protected_settings
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter configuration_settings
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter disable_gateway
⚠️ 1006 - ParaAdd connectedk8s update cmd connectedk8s update added parameter gateway_resource_id

@bavneetsingh16 bavneetsingh16 marked this pull request as draft July 23, 2024 05:41
Copy link

Hi @bavneetsingh16,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 23, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jul 23, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 30, 2024
@bavneetsingh16 bavneetsingh16 marked this pull request as ready for review September 27, 2024 21:40
@bavneetsingh16 bavneetsingh16 changed the title update cli to support arc gateway update cli to support arc gateway and workload identity Sep 27, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 30, 2024

Please fix CI issues

@bavneetsingh16
Copy link
Contributor Author

bavneetsingh16 commented Oct 1, 2024

Please fix CI issues

Thanks for reviewing it!

For azdev linter, I ran the cmd locally and it passes:
image

For azdev style, these are all the changes that pre existed.

@zhoxing-ms
Copy link
Contributor

@yanzhudd Could you please help review this PR when you have time?

@@ -3,6 +3,13 @@
Release History
===============

1.10.0
++++++
* Added support for arc gateway feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added support for arc gateway feature.
* Add support for arc gateway feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to specify which commands/parameters are impacted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks for reviewing!

@yanzhudd
Copy link
Contributor

yanzhudd commented Oct 9, 2024

please note Azure CLI team is only responsible for code style and specification but not business logic, so it is better to involve service team to review this PR as well.

@yanzhudd
Copy link
Contributor

yanzhudd commented Oct 9, 2024

please let me confirm with you if there are no tests added in this PR for the changes. If so, please add tests to verify if the changes meet your expectation.

@bavneetsingh16
Copy link
Contributor Author

@yanzhudd, Deeksha and I are members of the service team owning this CLI extension. I have made the necessary updates, and we have thoroughly reviewed and extensively tested them, including a bug bash session. Additionally, we utilized the custom .whl file for this version within our testing framework, which allows us to test across all regions, providing greater confidence. This testing covered all scenarios for the CLI extension and the newly introduced gateway changes.

Could you please review the changes again and merge if everything looks good?

@yanzhudd yanzhudd merged commit ebcbb04 into Azure:main Oct 10, 2024
19 of 20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=195845&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants