Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and Commit commands #7827

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

liorstauber
Copy link
Contributor

@liorstauber liorstauber commented Jul 25, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Added firewall policy Save&Commit commands:
az network firewall policy draft create
az network firewall policy draft update
az network firewall policy draft intrusion-detection add
az network firewall policy draft intrusion-detection remove
az network firewall policy draft intrusion-detection list
az network firewall policy rule-collection-group draft
az network firewall policy rule-collection-group draft create
az network firewall policy rule-collection-group draft update
az network firewall policy rule-collection-group draft collection add-nat-collection
az network firewall policy rule-collection-group draft collection add-filter-collection
az network firewall policy rule-collection-group draft collection remove
az network firewall policy rule-collection-group draft collection rule add
az network firewall policy rule-collection-group draft collection rule update
az network firewall policy rule-collection-group draft collection rule remove

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

aaz pr - Azure/aaz#530

Copy link

azure-client-tools-bot-prd bot commented Jul 25, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️azure-firewall
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd network firewall policy deploy cmd network firewall policy deploy added
⚠️ 1011 - SubgroupAdd network firewall policy draft sub group network firewall policy draft added
⚠️ 1011 - SubgroupAdd network firewall policy rule-collection-group draft sub group network firewall policy rule-collection-group draft added

Copy link

Hi @liorstauber,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 25, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

For more info about extension versioning, please refer to Extension version schema

@liorstauber liorstauber marked this pull request as ready for review July 25, 2024 12:28
@necusjz necusjz merged commit bf36b7e into Azure:main Jul 26, 2024
19 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ azure-firewall ] : https://dev.azure.com/azclitools/release/_build/results?buildId=176098&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants