Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pedantic packaging fix: probably not making a meaningful difference today but likely saving trouble in the future
packaging
connectedk8s
using the tooling recommended in current python packaging reveals thatHISTORY.rst
is not included in the sdist, and therefore not available for use bysetup.py
when building the wheel.per https://github.com/pypa/setuptools/blob/08bd31115732ece3cca50bd93f338e1b90dead34/docs/userguide/miscellaneous.rst#controlling-files-in-the-distribution, setuptools includes certain files by default - eg
README.md
- andHISTORY.rst
is not among them.Therefore explicitly package
HISTORY.rst
, after which this works fine.