Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containerapp] Remove GA commands which exist in azure-cli version 2.62.0 and release 0.3.54 #7837

Merged
merged 9 commits into from
Aug 1, 2024

Conversation

Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 31, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1008 - ParaPropAdd containerapp env certificate create cmd containerapp env certificate create update parameter validation_method: added property choices=['CNAME', 'HTTP', 'TXT']
⚠️ 1004 - CmdPropRemove containerapp env certificate delete cmd containerapp env certificate delete removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env certificate list cmd containerapp env certificate list removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp env list-usages cmd containerapp env list-usages removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp list-usages cmd containerapp list-usages removed property is_preview
⚠️ 1004 - CmdPropRemove containerapp show-custom-domain-verification-id cmd containerapp show-custom-domain-verification-id removed property is_preview

Copy link

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 31, 2024

Containerapp

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@Greedygre Greedygre changed the title [Containerapp] Remove GA commands which exists in azure-cli of version 2.62.0 and release 0.3.54 [Containerapp] Remove GA commands which exist in azure-cli version 2.62.0 and release 0.3.54 Jul 31, 2024
Copy link

github-actions bot commented Jul 31, 2024

⚠️ Release Suggestions

Module: containerapp

  • ⚠️ Please update VERSION to be 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 31, 2024

Please fix CI issues

Copy link
Contributor

@Seris370 Seris370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LGDoor
Copy link
Contributor

LGDoor commented Jul 31, 2024

LGTM

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 1, 2024
@yanzhudd yanzhudd removed do-not-merge release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Aug 1, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 1, 2024
@yanzhudd yanzhudd merged commit e823b58 into Azure:main Aug 1, 2024
27 of 28 checks passed
@wangzelin007
Copy link
Member

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_URL: https://dev.azure.com/azclitools/release/_build/results?buildId=177797&view=results

Last commit: https://github.com/Azure/azure-cli-extensions/commit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants