Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CVM functionality to vm repair: unlocking disks #7839

Merged
merged 17 commits into from
Aug 30, 2024

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Jul 31, 2024


This is a copy of #7821

This checklist is used to make sure that common guidelines for a pull request are followed.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair create -g RG -n VM --unlock-encrypted-vm --encrypted-vm-recovery-password "***"
Above command creates confidential rescue VM.

az vm repair run -g RG -n VM --run-id win-crowdstrike-fix-bootloop-cvm --run-on-repair
This to run script on disk.

az vm repair restore -g RG -n VM --verbose --debug> debugoutput

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jul 31, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️vm-repair
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd vm repair create cmd vm repair create added parameter encrypt_recovery_key

Copy link

Hi @Sandido,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 31, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jul 31, 2024

Hi @Sandido

Release Suggestions

Module: vm-repair

  • Update VERSION to 1.1.0 in src/vm-repair/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jul 31, 2024
@Sandido
Copy link
Member Author

Sandido commented Jul 31, 2024

@zhoxing-ms , @yonzhan , is there a script I can run to resolve the linter errors? The Flak8 failure?

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 5, 2024
@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Aug 8, 2024

image @Sandido Please take a look at this comment about the Flak8 failure.

There is currently no script to resolve the linter errors, you need to solve them yourself. But these issues will not block the merge of PRs for now. You can submit a separate new PR in the future to solve them

@yanzhudd
Copy link
Contributor

If you want to release a new extension version, please update the version in setup.py as well.

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 27, 2024
src/vm-repair/HISTORY.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Aug 29, 2024
@zhoxing-ms zhoxing-ms merged commit 63c0676 into Azure:main Aug 30, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants