Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCVMM] Fix VMM Server Connect command 1.1.1 release #7841

Merged

Conversation

hsurana06
Copy link
Member

@hsurana06 hsurana06 commented Aug 1, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az scvmm vmmserver connect - There is a fix needed in passing the vmmServerProperties correctly in the body. All calls are facing due to this properties API validation failure.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @hsurana06,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @hsurana06,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 1, 2024

SCVMM

@hsurana06
Copy link
Member Author

@yonzhan @kairu-ms @jsntcy

Thanks for the approval on the az cli PR #7778 yesterday.
Unfortunately, we have got a regression with this rollout of the new extension version. The vmmserver onboarding experience is impacted with this, customers would be unable to connect their VMMServer.
We caught this in our e2e pipeline immediately when this went public.

Added the fix for the failures observed with SCVMM cli v1.1.0 release

Looking for a hotfix to get this healthy.
Can you please help us with a quick release so that the customers are unblocked.

@hsurana06 hsurana06 changed the title [SCVMM] Fix VMM Server Connect command 1.1.0 release [SCVMM] Fix VMM Server Connect command 1.1.1 release Aug 1, 2024
@hsurana06
Copy link
Member Author

@kairu-ms - I have updated the release version and history.rst for changelog. Can you help merge this PR and what would be ETA for releasing this as a hotfix once PR is merged?

@kairu-ms kairu-ms merged commit 9415618 into Azure:main Aug 1, 2024
17 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 1, 2024

[Release] Update index.json for extension [ scvmm ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177941&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants