-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ACA dynamic session NodeLTS support in Azure CLI #7843
Conversation
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp sessionpool create | cmd containerapp sessionpool create update parameter container_type : updated property choices from ['CustomContainer', 'PythonLTS'] to ['CustomContainer', 'NodeLTS', 'PythonLTS'] |
Hi @ASHIQUEMD, |
Hi @ASHIQUEMD, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Signed-off-by: MD Ashique <[email protected]>
Here is the test |
About the test failed: I will rerun and update the recording files in PR: #7913 |
Signed-off-by: MD Ashique <[email protected]>
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: MD Ashique <[email protected]>
Signed-off-by: Ashique MD <[email protected]>
Signed-off-by: Ashique MD <[email protected]>
self.cmd('configure --defaults location={}'.format(location)) | ||
|
||
env_name = self.create_random_name(prefix='aca-sp-env', length=24) | ||
create_containerapp_env(self, env_name, resource_group, TEST_LOCATION) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need to create env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ASHIQUEMD
The env_name
is unused, please remove it is not necessary:
The code about creating env at test_containerapp_session_code_interpreter
also not needed
Line 24 in f0677b5
env_name = self.create_random_name(prefix='aca-sp-env', length=24) |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
please fix the CI issues |
Hi @yanzhudd What should we do? Thanks |
Hi @Greedygre sorry for the inconvenience. Please revert the PR that updated the API version as well. |
Signed-off-by: Ashique MD <[email protected]>
Signed-off-by: Ashique MD <[email protected]>
After this PR:#7919 merged, sync main branch the CI will fix. |
Hi @ASHIQUEMD |
Signed-off-by: Ashique MD <[email protected]>
Signed-off-by: Ashique MD <[email protected]>
Signed-off-by: Ashique MD <[email protected]>
This PR includes below changes.
NodeLTS
forcontainer_type
parameter inaz containerapp sessionpool create
command.Related command
Create Session Pool
Execute Code
Scenarios tested
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.