Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Firewall IDPS new parameter - IDPS Profile #7856

Merged
merged 27 commits into from
Aug 8, 2024

Conversation

NiviShenker
Copy link
Contributor

@NiviShenker NiviShenker commented Aug 5, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

New intrusion detection parameter - IDPS profile. It can be passed as a parameter to policy/draft policy.
relevant commands:
az network firewall policy create, az network firewall policy update, az network firewall policy draft create, az network firewall policy draft update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

aaz link: https://github.com/Azure/aaz/pull/539/files#diff-044a257bc835ec063a135a92edf89aa0faaee20af8797e58e39c6f12662b33e8

Copy link

azure-client-tools-bot-prd bot commented Aug 5, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️azure-firewall
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network firewall policy create cmd network firewall policy create added parameter idps_profile
⚠️ 1006 - ParaAdd network firewall policy intrusion-detection add cmd network firewall policy intrusion-detection add added parameter idps_profile
⚠️ 1006 - ParaAdd network firewall policy intrusion-detection remove cmd network firewall policy intrusion-detection remove added parameter idps_profile
⚠️ 1006 - ParaAdd network firewall policy update cmd network firewall policy update added parameter idps_profile

Copy link

Hi @NiviShenker,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @NiviShenker,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 5, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@NiviShenker NiviShenker changed the title Nivishenker/idps profiles Azure Firewall IDPS new parameter - IDPS Profile Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Aug 5, 2024

@NiviShenker NiviShenker marked this pull request as ready for review August 6, 2024 06:56
@necusjz necusjz merged commit e416e84 into Azure:main Aug 8, 2024
19 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 8, 2024

[Release] Update index.json for extension [ azure-firewall ] : https://dev.azure.com/azclitools/release/_build/results?buildId=179965&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants