Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(acns): add advanced network security fqdn policy feature to az aks create/update #7860

Merged
merged 10 commits into from
Aug 13, 2024

Conversation

jshr-w
Copy link
Contributor

@jshr-w jshr-w commented Aug 6, 2024

Add azcli commands for enabling Advanced Network Security FQDN policy feature for aks-preview extension.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --enable-fqdn-policy
az aks update --enable-fqdn-policy
az aks update --disable-fqdn-policy

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 6, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_acns
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_fqdn_policy
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_acns
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_fqdn_policy
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_acns
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_fqdn_policy

Copy link

Hi @jshr-w,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @jshr-w,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 6, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@jshr-w jshr-w changed the title Jshr/fqdncli feat(acns): add advanced network security fqdn policy feature to az aks create/update Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_create_with_enable_fqdn_policy
  • test_aks_update_enable_fqdn_policy

@FumingZhang
Copy link
Member

FumingZhang commented Aug 8, 2024

Queued live test to validate the change.

  • test_aks_create_with_enable_fqdn_policy
  • test_aks_update_enable_fqdn_policy

The previous live test failed, seems the feature is protected by a feature flag or toggle? Is the feature available in all regions? If it supports bypassing validation via akshttpcustomfeatures header, please modify the test accordingly.

Re-queued live test in staging env, test passed!

  • test_aks_create_with_enable_fqdn_policy
  • test_aks_update_enable_fqdn_policy
  • test_aks_update_enable_fqdn_policy

@jshr-w
Copy link
Contributor Author

jshr-w commented Aug 8, 2024

The toggle to release feature is currently rolling out, should get to eastus2euap by tomorrow.

@FumingZhang
Copy link
Member

The toggle to release feature is currently rolling out, should get to eastus2euap by tomorrow.

If the feature availability is controlled by toggle, there is a problem that it cannot be executed smoothly by the cli runner (something similar to runner, run tests at fixed intervals in a region in prod sub), please exclude your newly added cases in the following configuration file src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json

@jshr-w
Copy link
Contributor Author

jshr-w commented Aug 9, 2024

Thanks for clarifying! Disabled the test cases until feature rolls out fully to prod.

@jshr-w
Copy link
Contributor Author

jshr-w commented Aug 12, 2024

Here is the passing tests run in staging. I have added all tests to the ext_matrix to be excluded from the pipeline until the feature is fully rolled out to all regions.

Tests:

  • test_aks_create_with_enable_fqdn_policy
  • test_aks_update_enable_fqdn_policy
  • test_aks_update_enable_fqdn_policy
  • test_aks_create_with_enable_acns
  • test_aks_create_with_enable_acns_complex
  • test_aks_update_enable_acns

@zhoxing-ms
Copy link
Contributor

@FumingZhang Could you please help review it again?

@zhoxing-ms zhoxing-ms merged commit 13664cc into Azure:main Aug 13, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=181057&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants