-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(acns): add advanced network security fqdn policy feature to az aks create/update #7860
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks create | cmd aks create added parameter enable_acns |
||
aks create | cmd aks create added parameter enable_fqdn_policy |
||
aks update | cmd aks update added parameter disable_acns |
||
aks update | cmd aks update added parameter disable_fqdn_policy |
||
aks update | cmd aks update added parameter enable_acns |
||
aks update | cmd aks update added parameter enable_fqdn_policy |
Hi @jshr-w, |
Hi @jshr-w, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test to validate the change.
- test_aks_create_with_enable_fqdn_policy
- test_aks_update_enable_fqdn_policy
The previous live test failed, seems the feature is protected by a feature flag or toggle? Is the feature available in all regions? If it supports bypassing validation via akshttpcustomfeatures header, please modify the test accordingly. Re-queued live test in staging env, test passed!
|
The toggle to release feature is currently rolling out, should get to eastus2euap by tomorrow. |
If the feature availability is controlled by toggle, there is a problem that it cannot be executed smoothly by the cli runner (something similar to runner, run tests at fixed intervals in a region in prod sub), please exclude your newly added cases in the following configuration file |
Thanks for clarifying! Disabled the test cases until feature rolls out fully to prod. |
Here is the passing tests run in staging. I have added all tests to the ext_matrix to be excluded from the pipeline until the feature is fully rolled out to all regions. Tests:
|
@FumingZhang Could you please help review it again? |
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=181057&view=results |
Add azcli commands for enabling Advanced Network Security FQDN policy feature for aks-preview extension.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --enable-fqdn-policy
az aks update --enable-fqdn-policy
az aks update --disable-fqdn-policy
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.