-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CosmosDB RP API Version 2024-09-01-preview #7885
base: main
Are you sure you want to change the base?
Add CosmosDB RP API Version 2024-09-01-preview #7885
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
cosmosdb copy create | cmd cosmosdb copy create added parameter dest_mongo_vcore |
||
cosmosdb copy create | cmd cosmosdb copy create update parameter dest_account : removed property required=True |
||
cosmosdb create | cmd cosmosdb create update parameter server_version : updated property choices from ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0'] to ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0', '7.0'] |
||
cosmosdb update | cmd cosmosdb update update parameter server_version : updated property choices from ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0'] to ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0', '7.0'] |
Hi @carjackson-msft, |
DRAFT |
|
Adding support for Azure CosmosDB for MongoDB(RU) to Azure CosmosDB for MongoDB(vCore) container copy
fix line endings to lf
…n-msft/azure-cli-extensions into dev/2024-09-01-preview
…xtensions into dev/2024-09-01-preview
Please fix linter failure |
Fixed linter error
Fixing linter & styling errors
Fixed, thanks. CC: @srwshkrshnn |
src/cosmosdb-preview/setup.py
Outdated
@@ -16,7 +16,7 @@ | |||
|
|||
# TODO: Confirm this is the right version number you want and it matches your | |||
# HISTORY.rst entry. | |||
VERSION = '1.0.1' | |||
VERSION = '1.0.1b2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 1.0.1b2
? There's no 1.0.1b1
before🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @evelyn-ys, I had originally bumped this to 1.1.0 since we are adding a feature, but this resulted in a build error and a comment suggesting it be updated to 1.0.1b2 version.
Let me try setting it to 1.1.0 again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evelyn-ys it appears the version check is failing again, could you please let me know what the appropriate version would be if we are not setting it to the required version of 1.0.1b2?
Failing check: https://github.com/Azure/azure-cli-extensions/actions/runs/11109431994/job/30864989846?pr=7885
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @evelyn-ys, per the comment and the build failing due to this versioning, I have reverted back to the required versioning as stated in the github bot comment to allow the builds to pass. If a different version is needed (or overrides are needed) please let me or my colleague @pjohari-ms know and we can make the necessary change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllyW Can you help with the version definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @carjackson-msft cosmos-db-preview 1.0.1
is preview
version cause it has tag "azext.isPreview": true
here
azure-cli-extensions/src/cosmosdb-preview/azext_cosmosdb_preview/azext_metadata.json
Line 2 in f5f8289
"azext.isPreview": true, |
Therefore, after we have enforced new semantic versioning schema this May (https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md#versioning-of-azure-cli-extension), it takes the old release version as 1.0.1b1
and the next version would be 1.0.1b2
, according to this transition table: https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md#cli-extension-version-transition-table
Since this pr actually modified cmd interfaces, 1.1.0b1
makes sense, so minor
label is added here to enable 1.1.0b1
for this pr. If you have other concerns, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AllyW @evelyn-ys Update the minor versioning to 1.1.0b1 instead
This reverts commit da6ead7.
This reverts commit 986fc1f.
It seems to be quite long time since PR created. Pls sync with latest cli dev branch and rerun tests again |
@evelyn-ys Merged the PR with main, please take a look again. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@pjohari-ms I mean, you need to sync latest |
@evelyn-ys Thanks. Updated cli with dev branch and ran the setup again, and re recorded all tests as a precaution. Please take a look once more. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@evelyn-ys pinged you on teams chat to understand the issue - the tests are looking for wrong API version? |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.