Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CosmosDB RP API Version 2024-09-01-preview #7885

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

carjackson-msft
Copy link
Member

@carjackson-msft carjackson-msft commented Aug 14, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Aug 14, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️cosmosdb-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd cosmosdb copy create cmd cosmosdb copy create added parameter dest_mongo_vcore
⚠️ 1009 - ParaPropRemove cosmosdb copy create cmd cosmosdb copy create update parameter dest_account: removed property required=True
⚠️ 1010 - ParaPropUpdate cosmosdb create cmd cosmosdb create update parameter server_version: updated property choices from ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0'] to ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0', '7.0']
⚠️ 1010 - ParaPropUpdate cosmosdb update cmd cosmosdb update update parameter server_version: updated property choices from ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0'] to ['3.2', '3.6', '4.0', '4.2', '5.0', '6.0', '7.0']

Copy link

Hi @carjackson-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 14, 2024

DRAFT

Copy link

github-actions bot commented Aug 14, 2024

carjackson-msft and others added 4 commits August 16, 2024 11:41
Adding support for Azure CosmosDB for MongoDB(RU) to Azure CosmosDB for MongoDB(vCore) container copy
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 12, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 18, 2024
@carjackson-msft carjackson-msft marked this pull request as ready for review September 24, 2024 15:42
@carjackson-msft carjackson-msft changed the title [DRAFT] Add CosmosDB RP API Version 2024-09-01-preview Add CosmosDB RP API Version 2024-09-01-preview Sep 24, 2024
@evelyn-ys
Copy link
Member

Please fix linter failure

@carjackson-msft
Copy link
Member Author

Please fix linter failure

Fixed, thanks. CC: @srwshkrshnn

@@ -16,7 +16,7 @@

# TODO: Confirm this is the right version number you want and it matches your
# HISTORY.rst entry.
VERSION = '1.0.1'
VERSION = '1.0.1b2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 1.0.1b2? There's no 1.0.1b1 before🤔

Copy link
Member Author

@carjackson-msft carjackson-msft Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @evelyn-ys, I had originally bumped this to 1.1.0 since we are adding a feature, but this resulted in a build error and a comment suggesting it be updated to 1.0.1b2 version.

image

Let me try setting it to 1.1.0 again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evelyn-ys it appears the version check is failing again, could you please let me know what the appropriate version would be if we are not setting it to the required version of 1.0.1b2?

Failing check: https://github.com/Azure/azure-cli-extensions/actions/runs/11109431994/job/30864989846?pr=7885

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @evelyn-ys, per the comment and the build failing due to this versioning, I have reverted back to the required versioning as stated in the github bot comment to allow the builds to pass. If a different version is needed (or overrides are needed) please let me or my colleague @pjohari-ms know and we can make the necessary change.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllyW Can you help with the version definition?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @carjackson-msft cosmos-db-preview 1.0.1 is preview version cause it has tag "azext.isPreview": true here

.

Therefore, after we have enforced new semantic versioning schema this May (https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md#versioning-of-azure-cli-extension), it takes the old release version as 1.0.1b1 and the next version would be 1.0.1b2, according to this transition table: https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md#cli-extension-version-transition-table

Since this pr actually modified cmd interfaces, 1.1.0b1 makes sense, so minor label is added here to enable 1.1.0b1 for this pr. If you have other concerns, please let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllyW @evelyn-ys Update the minor versioning to 1.1.0b1 instead

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 30, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 2, 2024
@AllyW AllyW added the minor release extension module with version minor upgraded label Oct 9, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 9, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 15, 2024
@evelyn-ys
Copy link
Member

It seems to be quite long time since PR created. Pls sync with latest cli dev branch and rerun tests again

@pjohari-ms
Copy link
Member

@evelyn-ys Merged the PR with main, please take a look again.

@evelyn-ys
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

@pjohari-ms I mean, you need to sync latest azure-cli repo's dev branch and run azdev setup again to reset your local env, and then you will find that current test recordings in cosmosdb extension can't work with latest cli dev. Pls rerun failed tests to fix CI

@pjohari-ms
Copy link
Member

@evelyn-ys Thanks. Updated cli with dev branch and ran the setup again, and re recorded all tests as a precaution. Please take a look once more.

@evelyn-ys
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pjohari-ms
Copy link
Member

@evelyn-ys pinged you on teams chat to understand the issue - the tests are looking for wrong API version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CosmosDB minor release extension module with version minor upgraded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants