Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quantum] Update Azure CLI to reject parameters for submitting classic QDK jobs #7987

Conversation

warren-jones
Copy link
Contributor

@warren-jones warren-jones commented Sep 17, 2024

Remove command parameters and supporting code pertaining to the fully deprecated QDK feature where Q# source code could previously be compiled and run directly from the CLI.

With the "Modern" QDK, #Q source code must be compiled into QIR bitcode or human-readable LLVM code before it can be submitted to the Quantum service by the CLI extension.

Revise help suggestions accordingly.


Related commands

az quantum run
az quantum execute (Uses same code as az quantum run)
az quantum job submit


A new version of this extension will not be released until at least one more PR is completed.


General Guidelines

  • Have you run azdev style <YOUR_EXT> locally?
  • Have you run python scripts/ci/test_index.py -q locally?
  • My extension version conforms to the Extension version schema

Copy link

azure-client-tools-bot-prd bot commented Sep 17, 2024

❌Azure CLI Extensions Breaking Change Test
❌quantum
rule cmd_name rule_message suggest_message
1007 - ParaRemove quantum execute cmd quantum execute removed parameter no_build please add back parameter no_build for cmd quantum execute
1007 - ParaRemove quantum execute cmd quantum execute removed parameter project please add back parameter project for cmd quantum execute
1008 - ParaPropAdd quantum execute cmd quantum execute update parameter job_input_file: added property required=True please remove property required=True for parameter job_input_file of cmd quantum execute
1008 - ParaPropAdd quantum execute cmd quantum execute update parameter job_input_format: added property required=True please remove property required=True for parameter job_input_format of cmd quantum execute
1007 - ParaRemove quantum job submit cmd quantum job submit removed parameter no_build please add back parameter no_build for cmd quantum job submit
1007 - ParaRemove quantum job submit cmd quantum job submit removed parameter project please add back parameter project for cmd quantum job submit
1008 - ParaPropAdd quantum job submit cmd quantum job submit update parameter job_input_file: added property required=True please remove property required=True for parameter job_input_file of cmd quantum job submit
1008 - ParaPropAdd quantum job submit cmd quantum job submit update parameter job_input_format: added property required=True please remove property required=True for parameter job_input_format of cmd quantum job submit
1007 - ParaRemove quantum run cmd quantum run removed parameter no_build please add back parameter no_build for cmd quantum run
1007 - ParaRemove quantum run cmd quantum run removed parameter project please add back parameter project for cmd quantum run
1008 - ParaPropAdd quantum run cmd quantum run update parameter job_input_file: added property required=True please remove property required=True for parameter job_input_file of cmd quantum run
1008 - ParaPropAdd quantum run cmd quantum run update parameter job_input_format: added property required=True please remove property required=True for parameter job_input_format of cmd quantum run
⚠️ 1008 - ParaPropAdd quantum execute cmd quantum execute update parameter program_args: added property id_part=resource_group
⚠️ 1009 - ParaPropRemove quantum execute cmd quantum execute update parameter program_args: removed property nargs=*
⚠️ 1010 - ParaPropUpdate quantum execute cmd quantum execute update parameter program_args: updated property name from program_args to resource_group_name
⚠️ 1010 - ParaPropUpdate quantum execute cmd quantum execute update parameter program_args: updated property options from [] to ['--resource-group', '-g']
⚠️ 1008 - ParaPropAdd quantum job submit cmd quantum job submit update parameter program_args: added property id_part=resource_group
⚠️ 1009 - ParaPropRemove quantum job submit cmd quantum job submit update parameter program_args: removed property nargs=*
⚠️ 1010 - ParaPropUpdate quantum job submit cmd quantum job submit update parameter program_args: updated property name from program_args to resource_group_name
⚠️ 1010 - ParaPropUpdate quantum job submit cmd quantum job submit update parameter program_args: updated property options from [] to ['--resource-group', '-g']
⚠️ 1008 - ParaPropAdd quantum run cmd quantum run update parameter program_args: added property id_part=resource_group
⚠️ 1009 - ParaPropRemove quantum run cmd quantum run update parameter program_args: removed property nargs=*
⚠️ 1010 - ParaPropUpdate quantum run cmd quantum run update parameter program_args: updated property name from program_args to resource_group_name
⚠️ 1010 - ParaPropUpdate quantum run cmd quantum run update parameter program_args: updated property options from [] to ['--resource-group', '-g']

Copy link

Hi @warren-jones,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 17, 2024

Draft - Do Not Merge

@warren-jones warren-jones changed the title [Draft - Do Not Merge] Update Azure CLI to reject parameters for submitting classic QDK jobs [Draft - Do Not Merge] [Quantum] Update Azure CLI to reject parameters for submitting classic QDK jobs Sep 17, 2024
Copy link

Hi @warren-jones

Release Suggestions

Module: quantum

  • Please log updates into to src/quantum/HISTORY.rst
  • Update VERSION to 1.0.0b4 in src/quantum/setup.py

Notes

src/quantum/azext_quantum/_help.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_help.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_help.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_help.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_help.py Outdated Show resolved Hide resolved
src/quantum/azext_quantum/_help.py Outdated Show resolved Hide resolved
@warren-jones warren-jones marked this pull request as ready for review September 26, 2024 23:30
@warren-jones warren-jones changed the title [Draft - Do Not Merge] [Quantum] Update Azure CLI to reject parameters for submitting classic QDK jobs [Quantum] Update Azure CLI to reject parameters for submitting classic QDK jobs Sep 26, 2024
@warren-jones
Copy link
Contributor Author

Hi @warren-jones, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

HISTORY.rst and setup.py updates will accompany an upcoming release PR as is customary in our extension-release workflow.

@kairu-ms kairu-ms merged commit f5be3e4 into Azure:main Oct 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants