Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TL toggle on vm repair create to allow nested virtualization on repair VMs #7991

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Sep 18, 2024


Trusted Launch does not currently allow Nested Virtualization connection. This is useful for our customer support engineers so we want to ensure they can continue this practice when needed.
This PR adds a toggle to turn off Trusted Launch in the repair VM. This will only occur when the user provides a decryption key for the vm.
In the standard case, the repair VM will not be Trusted Launch by default.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Sep 18, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️vm-repair
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd vm repair create cmd vm repair create added parameter disable_trusted_launch

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 18, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Sep 18, 2024

Hi @Sandido

Release Suggestions

Module: vm-repair

  • Update VERSION to 1.2.0 in src/vm-repair/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 20, 2024
@Sandido Sandido marked this pull request as ready for review September 20, 2024 16:06
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 20, 2024

Please fix CI issues

@Sandido
Copy link
Member Author

Sandido commented Sep 27, 2024

Please fix CI issues

The error is in the Extension Index calculation:
"
AssertionError: {'aze[979 chars]zure-identity (==1.17.1)', 'azure-identity==1.[910 chars]0.0'} != {'aze[979 chars]zure-mgmt-resource (<23.0.0,>=3.0.0)', 'azure-[855 chars]0.0'}
2024-09-20T16:10:38.7730738Z Diff is 3752 characters long. Set self.maxDiff to None to see it. : Metadata for ml-2.30.0-py3-none-any.whl in index doesn't match the expected of:
"

Seems unrelated to my changes. @yonzhan , is there a setting in the CI check for maxDiff that needs to be set?

@zhoxing-ms
Copy link
Contributor

@yanzhudd Could you please help take a look at this issue?

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 9, 2024
@zhoxing-ms zhoxing-ms merged commit 2127744 into Azure:main Oct 16, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants