Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Subscription } Migrate subscription to AAZ #8133

Merged
merged 13 commits into from
Oct 18, 2024

Conversation

Jing-song
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Migrate subscription to AAZ
AAZ model: Azure/aaz#587

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 15, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️subscription
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd account create cmd account create added parameter no_wait
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter display_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter display_name: added property type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter enrollment_account_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter enrollment_account_name: added property type=string
⚠️ 1010 - ParaPropUpdate account create cmd account create update parameter enrollment_account_name: updated property name from enrollment_account_name to enrollment_account_object_id
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter offer_type: added property aaz_type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter offer_type: added property type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter owner_object_id: added property aaz_type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter owner_object_id: added property type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter owner_spn: added property aaz_type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter owner_spn: added property type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter owner_upn: added property aaz_type=string
⚠️ 1008 - ParaPropAdd account create cmd account create update parameter owner_upn: added property type=string

Copy link

Hi @Jing-song,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 15, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Oct 15, 2024

Hi @Jing-song

⚠️ Release Requirements

Module: subscription

  • ⚠️ Remove azext.isPreview: true in azext_metadata.json for subscription

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 15, 2024
@yonzhan yonzhan requested a review from jsntcy October 15, 2024 03:45
@yonzhan yonzhan requested a review from kairu-ms October 15, 2024 04:09
@wangzelin007
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 15, 2024
@kairu-ms
Copy link
Contributor

Please verify the choices changed for offer-type argument in the breaking change log: from ['MS-AZR-0017P', 'MS-AZR-0148P', 'MS-AZR-USGOV-0015P', 'MS-AZR-USGOV-0017P', 'MS-AZR-USGOV-0148P'] to ['MS-AZR-0017P', 'MS-AZR-0148P']

@jsntcy jsntcy merged commit 5db579a into Azure:main Oct 18, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ subscription ] : https://dev.azure.com/azclitools/release/_build/results?buildId=198298&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants