-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Used vendored application insight sdk #9184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @yuwzho, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces vendored Application Insights SDK files to support Azure Spring Cloud extension functionality. The purpose is to include the necessary Application Insights management client operations within the spring extension's vendored dependencies.
Key changes include:
- Added 17 Application Insights operation modules covering components, workbooks, web tests, and configuration management
- All files follow the Microsoft AutoRest code generation pattern with proper Azure SDK conventions
- Includes proper error handling, pagination support, and both JSON and binary content type handling
Reviewed Changes
Copilot reviewed 61 out of 65 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
_workbook_templates_operations.py | Operations for managing Azure workbook templates including CRUD operations |
_work_item_configurations_operations.py | Operations for Application Insights work item configurations |
_web_tests_operations.py | Web test management operations with support for creating, updating and listing tests |
_web_test_locations_operations.py | Operations to list available web test locations |
_proactive_detection_configurations_operations.py | Management of proactive detection configurations |
_patch.py | SDK customization placeholder file |
_operations.py | Core operations listing for Application Insights |
_live_token_operations.py | Live metrics stream token generation operations |
_favorites_operations.py | Application Insights favorites management |
_export_configurations_operations.py | Continuous export configuration operations |
_deleted_workbooks_operations.py | Operations for managing deleted workbooks |
_components_operations.py | Core Application Insights component management operations |
_component_quota_status_operations.py | Quota status retrieval operations |
_component_linked_storage_accounts_operations.py | Linked storage account management |
_component_feature_capabilities_operations.py | Feature capability inquiry operations |
_component_current_billing_features_operations.py | Billing feature management operations |
_component_available_features_operations.py | Available features listing operations |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.