Skip to content

Conversation

yaotongms
Copy link
Member

@yaotongms yaotongms commented Sep 19, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az connectedmachine extension image list: removing --subscription as it should be a tenant-level command
az connectedmachine extension image show: removing --subscription as it should be a tenant-level command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings September 19, 2025 22:10
Copy link

azure-client-tools-bot-prd bot commented Sep 19, 2025

❌Azure CLI Extensions Breaking Change Test
❌connectedmachine
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate connectedmachine extension image list cmd connectedmachine extension image list update parameter extension_type: updated property options from ['--extension-type', '--type'] to ['--extension-type'] please change property options from ['--extension-type'] to ['--extension-type', '--type'] for parameter extension_type of cmd connectedmachine extension image list
1010 - ParaPropUpdate connectedmachine extension image list cmd connectedmachine extension image list update parameter publisher: updated property options from ['--publisher', '-p'] to ['--publisher'] please change property options from ['--publisher'] to ['--publisher', '-p'] for parameter publisher of cmd connectedmachine extension image list
1010 - ParaPropUpdate connectedmachine extension image show cmd connectedmachine extension image show update parameter extension_type: updated property options from ['--extension-type', '--type'] to ['--extension-type'] please change property options from ['--extension-type'] to ['--extension-type', '--type'] for parameter extension_type of cmd connectedmachine extension image show
1010 - ParaPropUpdate connectedmachine extension image show cmd connectedmachine extension image show update parameter publisher: updated property options from ['--publisher', '-p'] to ['--publisher'] please change property options from ['--publisher'] to ['--publisher', '-p'] for parameter publisher of cmd connectedmachine extension image show
1010 - ParaPropUpdate connectedmachine extension image show cmd connectedmachine extension image show update parameter version: updated property options from ['--name', '--version', '-n'] to ['--version'] please change property options from ['--version'] to ['--name', '--version', '-n'] for parameter version of cmd connectedmachine extension image show
⚠️ 1006 - ParaAdd connectedmachine extension image list cmd connectedmachine extension image list added parameter pagination_limit
⚠️ 1006 - ParaAdd connectedmachine extension image list cmd connectedmachine extension image list added parameter pagination_token
⚠️ 1009 - ParaPropRemove connectedmachine extension image show cmd connectedmachine extension image show update parameter extension_type: removed property id_part=child_name_2
⚠️ 1009 - ParaPropRemove connectedmachine extension image show cmd connectedmachine extension image show update parameter location: removed property id_part=name
⚠️ 1009 - ParaPropRemove connectedmachine extension image show cmd connectedmachine extension image show update parameter publisher: removed property id_part=child_name_1
⚠️ 1009 - ParaPropRemove connectedmachine extension image show cmd connectedmachine extension image show update parameter version: removed property id_part=child_name_3

Copy link

Hi @yaotongms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the connected machine extension image commands to use a new API version and endpoint structure. The changes remove subscription-level dependencies and add new metadata fields for extension images.

  • Updates minimum CLI core version from 2.57.0 to 2.75.0
  • Migrates from subscription-scoped to global extension metadata endpoints
  • Adds new extension metadata fields (architecture, signatures, URIs, operating system)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
azext_metadata.json Updates minimum CLI core version requirement
_show.py Refactors show command to use v2 API without subscription dependency and adds new metadata schema
_list.py Refactors list command to use v2 API with pagination support and adds new metadata schema

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Sep 19, 2025

@yaotongms
Copy link
Member Author

aaz PR: Azure/aaz#869

@yonzhan yonzhan requested a review from yanzhudd October 2, 2025 00:04
@necusjz
Copy link
Member

necusjz commented Oct 2, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Oct 2, 2025

❌Azure CLI Extensions Breaking Change Test

❌connectedmachine

rule
cmd_name
rule_message
suggest_message

1010 - ParaPropUpdate
connectedmachine extension image list
cmd connectedmachine extension image list update parameter extension_type: updated property options from ['--extension-type', '--type'] to ['--extension-type']
please change property options from ['--extension-type'] to ['--extension-type', '--type'] for parameter extension_type of cmd connectedmachine extension image list

1010 - ParaPropUpdate
connectedmachine extension image list
cmd connectedmachine extension image list update parameter publisher: updated property options from ['--publisher', '-p'] to ['--publisher']
please change property options from ['--publisher'] to ['--publisher', '-p'] for parameter publisher of cmd connectedmachine extension image list

1010 - ParaPropUpdate
connectedmachine extension image show
cmd connectedmachine extension image show update parameter extension_type: updated property options from ['--extension-type', '--type'] to ['--extension-type']
please change property options from ['--extension-type'] to ['--extension-type', '--type'] for parameter extension_type of cmd connectedmachine extension image show

1010 - ParaPropUpdate
connectedmachine extension image show
cmd connectedmachine extension image show update parameter publisher: updated property options from ['--publisher', '-p'] to ['--publisher']
please change property options from ['--publisher'] to ['--publisher', '-p'] for parameter publisher of cmd connectedmachine extension image show

1010 - ParaPropUpdate
connectedmachine extension image show
cmd connectedmachine extension image show update parameter version: updated property options from ['--name', '--version', '-n'] to ['--version']
please change property options from ['--version'] to ['--name', '--version', '-n'] for parameter version of cmd connectedmachine extension image show

⚠️ 1006 - ParaAdd
connectedmachine extension image list
cmd connectedmachine extension image list added parameter pagination_limit

⚠️ 1006 - ParaAdd
connectedmachine extension image list
cmd connectedmachine extension image list added parameter pagination_token

⚠️ 1009 - ParaPropRemove
connectedmachine extension image show
cmd connectedmachine extension image show update parameter extension_type: removed property id_part=child_name_2

⚠️ 1009 - ParaPropRemove
connectedmachine extension image show
cmd connectedmachine extension image show update parameter location: removed property id_part=name

⚠️ 1009 - ParaPropRemove
connectedmachine extension image show
cmd connectedmachine extension image show update parameter publisher: removed property id_part=child_name_1

⚠️ 1009 - ParaPropRemove
connectedmachine extension image show
cmd connectedmachine extension image show update parameter version: removed property id_part=child_name_3

are these breaking changes expected?

@necusjz
Copy link
Member

necusjz commented Oct 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants