Skip to content

Conversation

DomAyre
Copy link
Contributor

@DomAyre DomAyre commented Sep 24, 2025

Why

Addresses

How

  • Update the code to restore the "attach to first image in input" behaviour
  • Add two new commands: fragment push and fragment attach to allow the user to explicitly do one or the other (or both!)
  • Add new tests which run a local docker registry, and test that the fragments are generated, signed, pushed and attached as expected (as well as the default behaviour)

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 14:37
Copy link

azure-client-tools-bot-prd bot commented Sep 24, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️confcom
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd confcom acifragmentgen cmd confcom acifragmentgen added parameter out_signed_fragment
⚠️ 1011 - SubgroupAdd confcom fragment sub group confcom fragment added

Copy link

Hi @DomAyre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the behaviour of the --upload-fragment flag for acifragmentgen and adds two new command-line arguments for more explicit control over fragment operations.

  • Restores the default behavior of --upload-fragment to attach fragments to the first image in the input
  • Adds --push-fragment-to and --attach-fragment-to arguments for explicit fragment operations
  • Updates the certificate generation script to support custom output directories

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/confcom/samples/certs/create_certchain.sh Enhanced to accept an optional output directory parameter
src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py Added comprehensive tests using local Docker registry for fragment generation, signing, uploading, pushing, and attaching
src/confcom/azext_confcom/custom.py Restored default upload behavior and added support for new push/attach parameters
src/confcom/azext_confcom/_params.py Added command-line argument definitions for the new fragment operation parameters

Copy link

github-actions bot commented Sep 24, 2025

@DomAyre DomAyre changed the title Restore the behaviour of --upload-fragment for acifragmentgen [confcom] Restore the behaviour of --upload-fragment for acifragmentgen Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants