-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[confcom] Restore the behaviour of --upload-fragment
for acifragmentgen
#9223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
confcom acifragmentgen | cmd confcom acifragmentgen added parameter out_signed_fragment |
||
confcom fragment | sub group confcom fragment added |
Hi @DomAyre, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR restores the behaviour of the --upload-fragment
flag for acifragmentgen and adds two new command-line arguments for more explicit control over fragment operations.
- Restores the default behavior of
--upload-fragment
to attach fragments to the first image in the input - Adds
--push-fragment-to
and--attach-fragment-to
arguments for explicit fragment operations - Updates the certificate generation script to support custom output directories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/confcom/samples/certs/create_certchain.sh | Enhanced to accept an optional output directory parameter |
src/confcom/azext_confcom/tests/latest/test_confcom_acifragmentgen.py | Added comprehensive tests using local Docker registry for fragment generation, signing, uploading, pushing, and attaching |
src/confcom/azext_confcom/custom.py | Restored default upload behavior and added support for new push/attach parameters |
src/confcom/azext_confcom/_params.py | Added command-line argument definitions for the new fragment operation parameters |
|
--upload-fragment
for acifragmentgen--upload-fragment
for acifragmentgen
Why
Addresses
--upload-fragment
#9222How
fragment push
andfragment attach
to allow the user to explicitly do one or the other (or both!)This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)