Skip to content

Conversation

Shivani-Msft
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 22:27
Copy link

azure-client-tools-bot-prd bot commented Sep 25, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️network-manager
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network manager group create cmd network manager group create added parameter member_type
⚠️ 1006 - ParaAdd network manager group update cmd network manager group update added parameter member_type

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 25, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Subnet type network groups in the network-manager routing configuration functionality. The changes upgrade the API version from 2022-01-01 to 2024-07-01 and introduce a new member-type parameter for network groups.

  • Updates API version to 2024-07-01 across all network manager group operations
  • Adds member-type parameter with Subnet and VirtualNetwork enum options
  • Extends test coverage to include subnet group scenarios in routing configuration

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
setup.py Updates version to 3.0.1 and changelog comment
test_network_scenario.py Adds subnet group testing to routing configuration test
_wait.py Updates API version and adds member_type/resource_guid schema properties
_update.py Updates API version and adds member-type argument support
_show.py Updates API version and adds new schema properties
_list.py Updates API version and adds new schema properties
_delete.py Updates API version
_create.py Updates API version and adds member-type argument support
HISTORY.rst Adds changelog entries for versions 3.0.1 and 2.0.2


2.0.2
+++++
* Support Network group type Subnet for Routing configuration
Copy link
Preview

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entry for version 2.0.2 appears to be incorrectly placed. Since the current version is being updated to 3.0.1, having a newer feature description under an older version number (2.0.2) creates confusion in the release history.

Suggested change
* Support Network group type Subnet for Routing configuration

Copilot uses AI. Check for mistakes.

options=["--member-type"],
arg_group="Properties",
help="The type of the group member.",
enum={"Subnet": "Subnet", "VirtualNetwork": "VirtualNetwork"},
Copy link
Preview

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The member_type argument should have a default value specified since this is a new optional parameter. Consider adding default="VirtualNetwork" to maintain backward compatibility with existing scripts that don't specify this parameter.

Suggested change
enum={"Subnet": "Subnet", "VirtualNetwork": "VirtualNetwork"},
enum={"Subnet": "Subnet", "VirtualNetwork": "VirtualNetwork"},
default="VirtualNetwork",

Copilot uses AI. Check for mistakes.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Hi @Shivani-Msft

⚠️ Release Requirements

Module: network-manager

  • ⚠️ Please update VERSION to be 2.2.0 in src/network-manager/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 25, 2025
@necusjz
Copy link
Member

necusjz commented Sep 26, 2025

plz re-record the failed testcases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants