-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Feature udr01 #9233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature udr01 #9233
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
network manager group create | cmd network manager group create added parameter member_type |
||
network manager group update | cmd network manager group update added parameter member_type |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Subnet type network groups in the network-manager routing configuration functionality. The changes upgrade the API version from 2022-01-01 to 2024-07-01 and introduce a new member-type parameter for network groups.
- Updates API version to 2024-07-01 across all network manager group operations
- Adds member-type parameter with Subnet and VirtualNetwork enum options
- Extends test coverage to include subnet group scenarios in routing configuration
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
setup.py | Updates version to 3.0.1 and changelog comment |
test_network_scenario.py | Adds subnet group testing to routing configuration test |
_wait.py | Updates API version and adds member_type/resource_guid schema properties |
_update.py | Updates API version and adds member-type argument support |
_show.py | Updates API version and adds new schema properties |
_list.py | Updates API version and adds new schema properties |
_delete.py | Updates API version |
_create.py | Updates API version and adds member-type argument support |
HISTORY.rst | Adds changelog entries for versions 3.0.1 and 2.0.2 |
|
||
2.0.2 | ||
+++++ | ||
* Support Network group type Subnet for Routing configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry for version 2.0.2 appears to be incorrectly placed. Since the current version is being updated to 3.0.1, having a newer feature description under an older version number (2.0.2) creates confusion in the release history.
* Support Network group type Subnet for Routing configuration |
Copilot uses AI. Check for mistakes.
options=["--member-type"], | ||
arg_group="Properties", | ||
help="The type of the group member.", | ||
enum={"Subnet": "Subnet", "VirtualNetwork": "VirtualNetwork"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The member_type argument should have a default value specified since this is a new optional parameter. Consider adding default="VirtualNetwork"
to maintain backward compatibility with existing scripts that don't specify this parameter.
enum={"Subnet": "Subnet", "VirtualNetwork": "VirtualNetwork"}, | |
enum={"Subnet": "Subnet", "VirtualNetwork": "VirtualNetwork"}, | |
default="VirtualNetwork", |
Copilot uses AI. Check for mistakes.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
plz re-record the failed testcases. |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.