Skip to content

Conversation

ShichaoQiu
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings September 28, 2025 05:11
Copy link

azure-client-tools-bot-prd bot commented Sep 28, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate containerapp sessionpool create cmd containerapp sessionpool create update parameter container_type: updated property choices from ['CustomContainer', 'NodeLTS', 'PythonLTS'] to ['CustomContainer', 'GpuBase', 'NodeLTS', 'PythonLTS']

Copy link

Hi @ShichaoQiu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for two new container types (Shell and GpuBase) to the az containerapp sessionpool create command in the Azure Container Apps CLI extension.

Key changes:

  • Extends the available container types from 3 to 5 options
  • Adds comprehensive test coverage for the new container types
  • Updates documentation with usage examples

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

File Description
_params.py Adds Shell and GpuBase to the enum of supported container types
test_containerapp_sessionpool.py Adds test cases for the new container types and updates the existing test method name
_help.py Adds a usage example for the Shell container type
HISTORY.rst Documents the new feature in the changelog

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

Hi @ShichaoQiu

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b4 in src/containerapp/setup.py

Notes

@ShichaoQiu ShichaoQiu changed the title [Containerapp] az containerapp sessionpool create: Add Shell and GpuBase container types [Containerapp] az containerapp sessionpool create: Add GpuBase container type Sep 28, 2025
@yonzhan
Copy link
Collaborator

yonzhan commented Sep 28, 2025

Please fix CI issues

@Greedygre
Copy link
Contributor

The CI failed due to Microsoft.Storage upgrade api-version in azure-cli, I will create a PR to update this recording files.

@ShichaoQiu ShichaoQiu marked this pull request as draft September 29, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants