-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Containerapp] az containerapp sessionpool create
: Add GpuBase
container type
#9242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp sessionpool create | cmd containerapp sessionpool create update parameter container_type : updated property choices from ['CustomContainer', 'NodeLTS', 'PythonLTS'] to ['CustomContainer', 'GpuBase', 'NodeLTS', 'PythonLTS'] |
Hi @ShichaoQiu, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for two new container types (Shell
and GpuBase
) to the az containerapp sessionpool create
command in the Azure Container Apps CLI extension.
Key changes:
- Extends the available container types from 3 to 5 options
- Adds comprehensive test coverage for the new container types
- Updates documentation with usage examples
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
_params.py |
Adds Shell and GpuBase to the enum of supported container types |
test_containerapp_sessionpool.py |
Adds test cases for the new container types and updates the existing test method name |
_help.py |
Adds a usage example for the Shell container type |
HISTORY.rst |
Documents the new feature in the changelog |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Hi @ShichaoQiu Release SuggestionsModule: containerapp
Notes
|
az containerapp sessionpool create
: Add Shell
and GpuBase
container typesaz containerapp sessionpool create
: Add GpuBase
container type
Please fix CI issues |
The CI failed due to |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.