Skip to content

Conversation

DomAyre
Copy link
Contributor

@DomAyre DomAyre commented Sep 29, 2025

Why

Addresses

How

  • Base the per container group value of exclude_default_fragment from the input arg instead of always being False
  • Use a new unique value for exclude_default_fragment per container group
  • Remove marking of known failure in tests caused by this which skips those tests
  • Bump the version and update HISTORY.rst

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

@Copilot Copilot AI review requested due to automatic review settings September 29, 2025 12:23
Copy link

azure-client-tools-bot-prd bot commented Sep 29, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the --exclude-default-fragments flag functionality in the confcom extension. The flag was previously not working as intended because it was not properly propagating the input argument value to individual container groups.

  • Fixed the logic to base the per-container group value of exclude_default_fragment from the input argument instead of always defaulting to False
  • Introduced a unique variable exclude_default_fragments_this_group to properly handle the exclusion logic per container group
  • Removed a test skip marker for a previously failing test case related to this issue

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/confcom/setup.py Bumped version from 1.2.8 to 1.2.9
src/confcom/azext_confcom/tests/latest/test_confcom_acipolicygen_arm.py Removed test skip for the fixed exclude-default-fragments functionality
src/confcom/azext_confcom/security_policy.py Fixed the exclude_default_fragments logic to properly use the input argument value
src/confcom/HISTORY.rst Added changelog entry for the bugfix

Copy link

@DomAyre DomAyre force-pushed the fix-exclude-default-fragments branch from 0c19fd8 to 643a621 Compare October 1, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants