-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[confcom] Fix --exclude-default-fragments
#9248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the --exclude-default-fragments
flag functionality in the confcom extension. The flag was previously not working as intended because it was not properly propagating the input argument value to individual container groups.
- Fixed the logic to base the per-container group value of
exclude_default_fragment
from the input argument instead of always defaulting to False - Introduced a unique variable
exclude_default_fragments_this_group
to properly handle the exclusion logic per container group - Removed a test skip marker for a previously failing test case related to this issue
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/confcom/setup.py | Bumped version from 1.2.8 to 1.2.9 |
src/confcom/azext_confcom/tests/latest/test_confcom_acipolicygen_arm.py | Removed test skip for the fixed exclude-default-fragments functionality |
src/confcom/azext_confcom/security_policy.py | Fixed the exclude_default_fragments logic to properly use the input argument value |
src/confcom/HISTORY.rst | Added changelog entry for the bugfix |
|
0c19fd8
to
643a621
Compare
Why
Addresses
How
exclude_default_fragment
from the input arg instead of always being Falseexclude_default_fragment
per container groupThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)