-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added SQL DB Retry, SQLVM Delete and SQLMI Delete commands #9256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
data-migration | sub group data-migration added |
Hi @amarjeetkr, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new Data Migration commands for Azure CLI including SQL DB retry, SQL VM delete, and SQL Managed Instance delete operations. The changes also update the minimum CLI core version requirement to support the new functionality.
- Adds retry command for SQL Database migration operations
- Adds delete commands for SQL VM and SQL Managed Instance database migrations
- Updates minimum CLI core version to 2.75.0
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
azext_metadata.json |
Updates minimum CLI core version from 2.15.0 to 2.75.0 |
aaz/ directory |
Adds new AAZ-generated command modules for data migration operations |
__init__.py |
Integrates AAZ command loading into the extension |
class Delete(AAZCommand): | ||
"""Delete Database Migration resource. | ||
|
||
:example: Create or Update Database Migration resource with Minimum parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example description is incorrect. It says 'Create or Update' but this is a delete command. Should be 'Delete Database Migration resource with Minimum parameters.'
:example: Create or Update Database Migration resource with Minimum parameters. | |
:example: Delete Database Migration resource with Minimum parameters. |
Copilot uses AI. Check for mistakes.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Hi @amarjeetkr
|
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Released the first stable version with three new commands.
az data-migration sql-db retry
- Retry on going migration for the database.data-migration sql-managed-instance delete
- Delete SQL MI Database Migration resource.data-migration sql-vm delete
- Delete SQL VM Database Migration resource.Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.