-
Notifications
You must be signed in to change notification settings - Fork 1.4k
{AKS} Bump holmesgpt and add feedback slash command #9261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR bumps the holmesgpt dependency to version 0.14.3 and adds feedback functionality to allow users to provide feedback on the AKS agent's performance. The update includes enhanced AI debugging features and bug fixes in the holmesgpt library.
- Updates holmesgpt dependency from 0.12.6 to 0.14.3 (temporarily using git reference)
- Adds feedback slash command functionality with telemetry tracking
- Introduces privacy notice banner and configuration customization for holmesgpt
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
setup.py | Updates version to 1.0.0b5 and switches holmesgpt to git reference |
telemetry.py | Adds feedback tracking method with type validation |
agent.py | Integrates feedback callback and reorganizes holmesgpt customization |
_consts.py | Adds new constants for privacy notice and prometheus toolset configuration |
HISTORY.rst | Documents version 1.0.0b5 changes and new features |
"holmesgpt @ git+ssh://[email protected]/robusta-dev/holmesgpt@master", | ||
# "holmesgpt==0.14.3; python_version >= '3.10'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a git+ssh dependency reference to master branch creates instability and reproducibility issues. The commented line suggests version 0.14.3 should be used instead. Consider using the specific version once it's available on PyPI, or pin to a specific commit hash rather than master.
"holmesgpt @ git+ssh://[email protected]/robusta-dev/holmesgpt@master", | |
# "holmesgpt==0.14.3; python_version >= '3.10'", | |
"holmesgpt==0.14.3; python_version >= '3.10'", |
Copilot uses AI. Check for mistakes.
DEPENDENCIES = [ | ||
"holmesgpt==0.12.6; python_version >= '3.10'", | ||
"pytest-asyncio>=1.1.0", | ||
"holmesgpt @ git+ssh://[email protected]/robusta-dev/holmesgpt@master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for a new holmesgpt release over 0.14.2
The user interface:
Loaded models: ['azure/gpt-4.1']
✅ Toolset kubernetes/kube-prometheus-stack
✅ Toolset core_investigation
✅ Toolset internet
✅ Toolset datadog/rds
✅ Toolset bash
✅ Toolset runbook
✅ Toolset kubernetes/logs
✅ Toolset json_processor
✅ Toolset docker/core
✅ Toolset kubernetes/core
✅ Toolset kubernetes/live-metrics
✅ Toolset aks/core
✅ Toolset aks/node-health
Using 40 datasources (toolsets). To refresh: use flag
--refresh-toolsets
Creating LLM with model: azure/gpt-4.1
This tool uses AI to generate responses and may not always be accurate.
Welcome to AKS AGENT: Type '/exit' to exit, '/help' for commands, '/feedback' to share your thoughts.
User: /feedback
Privacy Notice: When you send us this feedback, you agree we may combine this information, which might include other diagnostic data, to help improve
Microsoft products and services.Processing of feedback data is governed by the Microsoft Products and Services Data Protection Addendum between your
organization and Microsoft, and the feedback you submit is considered Personal Data under that addendum. Privacy Statement
💡 Tip: Press Ctrl+C at any time to cancel feedback
Was this response useful to you? 👍(y)/👎(n): y
Do you want to provide any additional comments for feedback? (press Enter to skip):
ignore my comment, internal test only
✓ Feedback recorded (rating=👍, "ignore my comment, internal test only")
Do you want to submit this feedback? (Y/n):
Thank you for your feedback! 🙏
User: /exit
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.