-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[confcom] Fix --infrastructure-svn
and --include-fragments
combo
#9264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @DomAyre, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
--infrastructure-svn
and --fragments-json
combo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the --infrastructure-svn
and --fragments-json
command line option combination by modifying fragment comparison logic to prevent pulling the default infrastructure fragment when a minimum SVN is specified.
- Update fragment comparison logic to check only feed and issuer fields instead of the entire import statement
- Add test coverage to ensure the flag combination works correctly
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/confcom/azext_confcom/oras_proxy.py |
Modified fragment comparison to use only feed and issuer fields when determining default fragments |
src/confcom/azext_confcom/tests/latest/test_confcom_acipolicygen_arm.py |
Added test case for infrastructure_svn flag and updated test skip logic |
Multiple .rego files |
Added new policy files for testing the infrastructure SVN flag combination |
src/confcom/samples/aci/multi_container_groups/policy_fragment_plus_infrastructure_svn.rego
Show resolved
Hide resolved
--infrastructure-svn
and --fragments-json
combo--infrastructure-svn
and --include-fragments
combo
Hi @DomAyre Release SuggestionsModule: confcom
Notes
|
Why
Addresses:
--infrastructure-svn
with additional fragments #9263When you use
--infrastructure-svn
this sets theminimum_svm
field of the import statement for the default infrastructure fragmentLater in the code if
--include-fragments
is specified, we attempt to pull fragments but intend to skip the default fragment, however it compares the entire import statement and therefore fails to match on SVN, attempts to pull the feed and fails.How
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)