[containerapp env] Remove GA ingress, routing #9265
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Tratcher, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Tratcher Release SuggestionsModule: containerapp
Notes
|
Tratcher
changed the title
| g.custom_command('delete', 'delete_managed_environment', supports_no_wait=True, confirmation=True, exception_handler=ex_handler_factory()) | ||
| g.custom_command('update', 'update_managed_environment', supports_no_wait=True, exception_handler=ex_handler_factory()) | ||
|
|
||
| with self.command_group('containerapp env http-route-config', is_preview=True) as g: |
There was a problem hiding this comment.
To avoid breaking change, we can remove the is_preview=True in extension first.
Then after azure-cli release, we update "azext.minCliCoreVersion": <azure-cli-version> in azext_metadata.json first, then remove these GA commands in extension.
There was a problem hiding this comment.
what if we just wait to merge this until after the azure-cli release?
There was a problem hiding this comment.
@Tratcher It depends on if you mind customer will see the Preview tag if they already install latest containerapp extension and azure-cli version.
If you care the Preview Tag, it should separate to 2 PR.
There was a problem hiding this comment.
But yes we can just wait to merge until after the azure-cli release.
Besides I will discuss the azure-cli-extension containerapp module release plan for ignite with co-workers after holiday to double check if we have plan to release a new version to separate these.
These features are moving to the core CLI and no longer need to be overridden in the extension.
Greedygre/azure-cli#4
Also fixed a typo in the name of
create_vnet_subnetso it is the same in both repos.