[AKS] feat: Azure Monitor Metrics addon (v2) (Managed Prometheus) GA #26201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bragi92
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the May 2023 (2023-05-23) - For Build (Breaking change release) milestone
ghost
requested a review
from 
|
AKS |
ghost
added
the
zhoxing-ms
reviewed
May 6, 2023
Comment on lines
+13
to
+18
| dce_name = get_default_dce_name(cmd, mac_region, cluster_name) | ||
| dce_resource_id = "/subscriptions/{0}/resourceGroups/{1}/providers/Microsoft.Insights/dataCollectionEndpoints/{2}"\ | ||
| .format(cluster_subscription, cluster_resource_group_name, dce_name) | ||
| try: | ||
| armendpoint = cmd.cli_ctx.cloud.endpoints.resource_manager | ||
| dce_url = f"{armendpoint}{dce_resource_id}?api-version={DC_API}" |
zhoxing-ms
reviewed
May 6, 2023
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
Co-authored-by: Xing Zhou <[email protected]>
Co-authored-by: Xing Zhou <[email protected]>
…into kaveesh/ga_cli
|
Since your PR contains too much content, could you please refer to PR #25978 to write the descriptions of new commands and parameters into the |
I have updated the PR description following the pattern you described. |
|
@bragi92 Could you please resolve this CI issue? |
|
@zhoxing-ms I have fixed all the CI/CD issues and have tested out the changes locally on my test clusters and everything looks good to me. Please review it/merge it in if it looks good to you. |
zhoxing-ms
approved these changes
May 12, 2023
yash-nisar
pushed a commit
to yash-nisar/azure-cli
that referenced
this pull request
May 16, 2023
3 tasks
3 tasks
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
|
@bragi92 I was looking for similar feature in azure sdk for go package. Is there plan to add it there. Meanwhile, can you please suggest any workaround for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks update -n kaveeshcli22 -g kaveeshcli --enable-azure-monitor-metrics --enable-windows-recording-rulesaz aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --enable-windows-recording-rules --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"Description
GA update for Azure Monitor Metrics. The changes for public preview where merged into the az cli extensions repo in the following PR: Azure/azure-cli-extensions#5428
Testing Guide
az aks createandaz aks updateis being updated with the following parameters:To create a cluster with the Azure Monitor Metrics addon enabled and sending data to a particular Azure Monitor Workspace and linked with a Grafana instance run :
az aks create -n kaveeshcli1 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"To update an existing cluster with the Azure Monitor Metrics addon to a default workspace and to enable windows recording rules on it run :
az aks update-n kaveeshcli2 -g kaveeshcli --enable-azure-monitor-metrics --enable-windows-recording-rulesTo disable the Azure Monitor Metrics addon run :
az aks update-n kaveeshcli2 -g kaveeshcli --disable-azure-monitor-metricsHistory Notes
[AKS]
az aks create/update: Add parameter--enable-azure-monitor-metricsto enable managed prometheus (Azure Monitor Metrics Addon)[AKS]
az aks create/update: Add parameter--azure-monitor-workspace-resource-idto store metrics for the managed prometheus addon[AKS]
az aks create/update: Add parameter--grafana-resource-idto link the Azure Monitor Workspace with a Grafana instance for viewing metrics and dashboards[AKS]
az aks create/update: Add parameter--enable-windows-recording-rulesto enable windows recording rule groups on the Azure Monitor Workspace (by default they get created but are disabled)[AKS]
az aks create/update: Add parameter--ksm-metric-labels-allow-listto support the additional Kubernetes label keys that will be used in the resource' labels metric[AKS]
az aks create/update: Add parameter--ksm-metric-annotations-allow-listto support the Kubernetes annotations keys that will be used in the resource' labels metric[AKS]
az aks update: Add parameter--disable-azure-monitor-metricsto disable the Azure Monitor Metrics addonThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.