[AKS] BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity
#28906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FumingZhang
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @FumingZhang, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create update parameter enable_managed_identity: removed property default=True |
|
AKS |
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
commented
May 7, 2024
| # create | ||
| create_cmd = 'aks create --resource-group={resource_group} --name={name} --location={location} ' \ | ||
| '--dns-name-prefix={dns_name_prefix} --node-count=1 --ssh-key-value={ssh_key_value} ' \ | ||
| '--service-principal={service_principal} --client-secret={client_secret} --enable-managed-identity' |
There was a problem hiding this comment.
The case was testing using sp and enabling msi to create the cluster at the same time, which is not a valid scenario after this change.
matthchr
approved these changes
May 7, 2024
zhoxing-ms
approved these changes
May 8, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks createDescription
--enable-managed-identityand--service-principal/--client-secretat the same time will cause aMutuallyExclusiveArgumentError.--enable-managed-identityfromTruetoFalse.--service-principaland--client-secretare not specified at the same time, CLI will backfill the value of--enable-managed-identitytoTrueto maintain the same behavior as before (that is, create an cluster with managed system assigned identity by default).Testing Guide
History Notes
[AKS] BREAKING CHANGE:
az aks create: Specifying--enable-managed-identityand--service-principal/--client-secretat the same time will cause aMutuallyExclusiveArgumentError[AKS] BREAKING CHANGE:
az aks create: Change the default value of option--enable-managed-identityfromTruetoFalse[AKS]
az aks create: When options--service-principaland--client-secretare not specified at the same time, CLI will backfill the value of--enable-managed-identitytoTrueto maintain the same behavior as before (that is, create an cluster with managed system assigned identity by default)This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.