[AKS] az aks create az aks nodepool add/update: Add Trusted Launch options --enable-vtpm and --enable-secure-boot
#29272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilypan26
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @lilypan26, |
❌AzureCLI-BreakingChangeTest
|
|
AKS |
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29272 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
previously approved these changes
Jul 29, 2024
|
Requeued live test |
|
feature not ready, expected to be postponed to September |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@lilypan26 Could you resolve these CI issues and conflicts? |
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 10-08) |
zhoxing-ms
modified the milestones:
August 2024 (2024-09-03),
September 2024 (2024-10-08)
|
Live test failed with the following error |
|
@lilypan26 Could you please address these CI issues and comments? Please note that we are launching the release for this sprint this week. Please resolve all comments and CI issues by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 11-05) |
zhoxing-ms
modified the milestones:
September 2024 (2024-10-08),
October 2024 (2024-11-05)
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29272 in repo Azure/azure-cli |
lilypan26
force-pushed
the
lily/add-tl
branch
from
bb2ff52
to
84ca903
Compare
added 2 commits
October 15, 2024 13:11
|
successful live test run: https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=105831660&view=results |
|
Please fix CI issues |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Add trusted launch options
--enable-vtpm,--disable-vtpm,--enable-secure-boot,--disable-secure-bootto support enabling disabling vTPM and secure boot on AKS nodepools.Testing Guide
History Notes
[AKS]
az aks create: Add Trusted Launch options--enable-vtpmand--enable-secure-boot[AKS]
az aks nodepool add/update: Add Trusted Launch options--enable-vtpmand--enable-secure-bootThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.