update to node20 (#3594)

* update to node20 * update terraform azurerm version * node function fix
Azure · Mar 28, 2024 · 8f230dd · 8f230dd
1 parent 733bfdc
commit 8f230dd
Show file tree

Hide file tree

Showing 46 changed files with 71 additions and 71 deletions.
diff --git a/.github/workflows/cli-ci.yml b/.github/workflows/cli-ci.yml
@@ -22,7 +22,7 @@ jobs:
       - uses: actions/setup-go@v3
         with:
           go-version: "^1.21.0"
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
@@ -33,10 +33,10 @@ jobs:
   cspell-lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
       - run: npm install -g cspell
       - name: Spell check for CLI source code
         run: cspell lint '**/*.go' --config ./cli/azd/.vscode/cspell.yaml --root ./cli/azd --no-progress

diff --git a/.github/workflows/cspell-misc.yml b/.github/workflows/cspell-misc.yml
@@ -16,10 +16,10 @@ jobs:
   cspell-lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
       - run: npm install -g cspell
       - name: Spell check for general files
         run: cspell lint '**/*' --config ./.vscode/cspell.misc.yaml --relative --no-progress
diff --git a/.github/workflows/devcontainer-feature-release.yml b/.github/workflows/devcontainer-feature-release.yml
@@ -23,7 +23,7 @@ jobs:
     environment:
       name: deploy-devcontainer-feature
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: "Publish Features"
         uses: devcontainers/action@v1

diff --git a/.github/workflows/devcontainer-feature-test.yml b/.github/workflows/devcontainer-feature-test.yml
@@ -25,7 +25,7 @@ jobs:
             "mcr.microsoft.com/devcontainers/base:debian",
           ]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: "Install latest devcontainer CLI"
         run: npm install -g @devcontainers/cli
@@ -37,7 +37,7 @@ jobs:
   test-scenarios:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: "Install latest devcontainer CLI"
         run: npm install -g @devcontainers/cli
@@ -49,7 +49,7 @@ jobs:
   test-global:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: "Install latest devcontainer CLI"
         run: npm install -g @devcontainers/cli

diff --git a/.github/workflows/devops-ext-ci.yml b/.github/workflows/devops-ext-ci.yml
@@ -16,10 +16,10 @@ jobs:
   build-test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
       - name: Install dependencies
         run: |
           npm install -g npm

diff --git a/.github/workflows/lint-bicep.yml b/.github/workflows/lint-bicep.yml
@@ -13,7 +13,7 @@ jobs:
   bicep-lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Lint .bicep files
         run: $ErrorActionPreference='Continue'; eng/scripts/Test-BicepLint.ps1 -Verbose
         shell: pwsh
diff --git a/.github/workflows/schema-ci.yml b/.github/workflows/schema-ci.yml
@@ -14,9 +14,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
       - run: npm install -g jsonlint
       - name: Validate schemas JSON
         run: jsonlint schemas/**/*.json -c
diff --git a/.github/workflows/templates-ci.yml b/.github/workflows/templates-ci.yml
@@ -20,10 +20,10 @@ jobs:
   cspell-lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
       - run: npm install -g cspell
       - name: Spell check for templates
         run: cspell lint '**/*' --config ./templates/cspell.yaml --root ./templates --no-progress
diff --git a/.github/workflows/vscode-ci.yml b/.github/workflows/vscode-ci.yml
@@ -16,10 +16,10 @@ jobs:
   cspell-lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
-          node-version: "18"
+          node-version: "20"
       - run: npm install -g cspell
       - name: Spell check for vscode extension
         run: cspell lint '**/*.ts' --config ./ext/vscode/.vscode/cspell.yaml --root ./ext/vscode --no-progress
@@ -28,17 +28,17 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [18.x]
+        node-version: [20.x]
         os: [macos-latest, ubuntu-latest, windows-latest]
         include:
           - os: ubuntu-latest
             upload-artifact: true
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
 

diff --git a/cli/azd/test/functional/testdata/recordings/Test_CLI_DevCenter_Init_Up_Down.yaml b/cli/azd/test/functional/testdata/recordings/Test_CLI_DevCenter_Init_Up_Down.yaml
diff --git a/cli/azd/test/functional/testdata/samples/resourcegroupterraform/infra/provider.tf b/cli/azd/test/functional/testdata/samples/resourcegroupterraform/infra/provider.tf
@@ -5,7 +5,7 @@ terraform {
   required_version = ">= 1.1.7, < 2.0.0"
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/cli/azd/test/functional/testdata/samples/resourcegroupterraformremote/infra/provider.tf b/cli/azd/test/functional/testdata/samples/resourcegroupterraformremote/infra/provider.tf
@@ -7,7 +7,7 @@ terraform {
   }
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/templates/common/.devcontainer/devcontainer.json/aks/nodejs/devcontainer.json b/templates/common/.devcontainer/devcontainer.json/aks/nodejs/devcontainer.json
@@ -1,6 +1,6 @@
 {
     "name": "Azure Developer CLI",
-    "image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
+    "image": "mcr.microsoft.com/devcontainers/javascript-node:20-bullseye",
     "features": {
         "ghcr.io/devcontainers/features/docker-in-docker:2": {
         },

diff --git a/templates/common/.devcontainer/devcontainer.json/java/devcontainer.json b/templates/common/.devcontainer/devcontainer.json/java/devcontainer.json
@@ -1,6 +1,6 @@
 {
     "name": "Azure Developer CLI",
-    "image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
+    "image": "mcr.microsoft.com/devcontainers/javascript-node:20-bullseye",
     "features": {
         "ghcr.io/devcontainers/features/docker-in-docker:2": {
         },

diff --git a/templates/common/.devcontainer/devcontainer.json/java/terraform/devcontainer.json b/templates/common/.devcontainer/devcontainer.json/java/terraform/devcontainer.json
@@ -1,6 +1,6 @@
 {
     "name": "Azure Developer CLI",
-    "image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
+    "image": "mcr.microsoft.com/devcontainers/javascript-node:20-bullseye",
     "features": {
         "ghcr.io/devcontainers/features/azure-cli:1": {
         },

diff --git a/templates/common/.devcontainer/devcontainer.json/nodejs/devcontainer.json b/templates/common/.devcontainer/devcontainer.json/nodejs/devcontainer.json
@@ -1,6 +1,6 @@
 {
     "name": "Azure Developer CLI",
-    "image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
+    "image": "mcr.microsoft.com/devcontainers/javascript-node:20-bullseye",
     "features": {
         "ghcr.io/devcontainers/features/docker-in-docker:2": {
         },

diff --git a/templates/common/.devcontainer/devcontainer.json/nodejs/func/devcontainer.json b/templates/common/.devcontainer/devcontainer.json/nodejs/func/devcontainer.json
@@ -1,6 +1,6 @@
 {
     "name": "Azure Developer CLI",
-    "image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
+    "image": "mcr.microsoft.com/devcontainers/javascript-node:20-bullseye",
     "features": {
         "ghcr.io/devcontainers/features/docker-in-docker:2": {
         },

diff --git a/templates/common/.devcontainer/devcontainer.json/nodejs/terraform/devcontainer.json b/templates/common/.devcontainer/devcontainer.json/nodejs/terraform/devcontainer.json
@@ -1,6 +1,6 @@
 {
     "name": "Azure Developer CLI",
-    "image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
+    "image": "mcr.microsoft.com/devcontainers/javascript-node:20-bullseye",
     "features": {
         "ghcr.io/devcontainers/features/azure-cli:1": {
         },

diff --git a/templates/common/.github/workflows/func/azure-dev.yml b/templates/common/.github/workflows/func/azure-dev.yml
@@ -26,7 +26,7 @@ jobs:
       AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install azd
         uses: Azure/[email protected]

diff --git a/templates/common/.github/workflows/java/azure-dev.yml b/templates/common/.github/workflows/java/azure-dev.yml
@@ -26,7 +26,7 @@ jobs:
       AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install azd
         uses: Azure/[email protected]

diff --git a/templates/common/.github/workflows/java/terraform/azure-dev.yml b/templates/common/.github/workflows/java/terraform/azure-dev.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install azd
         uses: Azure/[email protected]
@@ -29,7 +29,7 @@ jobs:
           chmod +x ${GITHUB_WORKSPACE}/src/api/mvnw
 
       - name: Install Nodejs
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 18
 

diff --git a/templates/common/.github/workflows/nodejs/bicep/azure-dev.yml b/templates/common/.github/workflows/nodejs/bicep/azure-dev.yml
@@ -26,13 +26,13 @@ jobs:
       AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install azd
         uses: Azure/[email protected]
 
       - name: Install Nodejs
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 18
 

diff --git a/templates/common/.github/workflows/nodejs/func/azure-dev.yml b/templates/common/.github/workflows/nodejs/func/azure-dev.yml
@@ -26,13 +26,13 @@ jobs:
       AZURE_CREDENTIALS: ${{ secrets.AZURE_CREDENTIALS }}
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install azd
         uses: Azure/[email protected]
 
       - name: Install Nodejs
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 18
 

diff --git a/templates/common/.github/workflows/nodejs/terraform/azure-dev.yml b/templates/common/.github/workflows/nodejs/terraform/azure-dev.yml
@@ -15,13 +15,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install azd
         uses: Azure/[email protected]
 
       - name: Install Nodejs
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 18
 

diff --git a/templates/common/.github/workflows/terraform/azure-dev.yml b/templates/common/.github/workflows/terraform/azure-dev.yml
@@ -15,13 +15,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Install azd
         uses: Azure/[email protected]
 
       - name: Install Nodejs
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
           node-version: 18
 

diff --git a/templates/common/infra/terraform/core/database/cosmos/cosmos.tf b/templates/common/infra/terraform/core/database/cosmos/cosmos.tf
@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/templates/common/infra/terraform/core/database/postgresql/postgresql.tf b/templates/common/infra/terraform/core/database/postgresql/postgresql.tf
@@ -5,7 +5,7 @@ locals {
 terraform {
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/templates/common/infra/terraform/core/gateway/apim-api/apim-api.tf b/templates/common/infra/terraform/core/gateway/apim-api/apim-api.tf
@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/templates/common/infra/terraform/core/gateway/apim/apim.tf b/templates/common/infra/terraform/core/gateway/apim/apim.tf
@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/templates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava.tf b/templates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava.tf
@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/templates/common/infra/terraform/core/host/appservice/appservicenode/appservicenode.tf b/templates/common/infra/terraform/core/host/appservice/appservicenode/appservicenode.tf
@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {

diff --git a/...es/common/infra/terraform/core/host/appservice/appservicenode/appservicenode_variables.tf b/...es/common/infra/terraform/core/host/appservice/appservicenode/appservicenode_variables.tf
@@ -47,7 +47,7 @@ variable "resource_token" {
 variable "node_version" {
   description = "the application stack node version to set for the app service."
   type        = string
-  default     = "18-lts"
+  default     = "20-lts"
 }
 
 variable "always_on" {

diff --git a/templates/common/infra/terraform/core/host/appservice/appservicepython/appservicepython.tf b/templates/common/infra/terraform/core/host/appservice/appservicepython/appservicepython.tf
@@ -1,7 +1,7 @@
 terraform {
   required_providers {
     azurerm = {
-      version = "~>3.47.0"
+      version = "~>3.97.1"
       source  = "hashicorp/azurerm"
     }
     azurecaf = {