-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding devcontainer definition #1118
Conversation
Co-authored-by: Daniel Jurek <[email protected]>
- test jobs need to pass before deploy passes - deploy job linked to environment for approval
Hi @aaronpowell. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @aaronpowell. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Hi @aaronpowell. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
/reopen |
@karolz-ms , @jongio ping |
Co-authored-by: Matt Ellis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - One small note about setting the version here to something like 0.1.0
to start with, since we'll want to save 1.0.0
for once we have a little more confidence about these changes.
If @danieljurek is happy with the GitHub action stuff (I think he mentioned at standup today that publishing this from GitHub actions and to the ghcr associated with our repository is right thing to do) I think we can land this.
Thanks @aaronpowell and @hemarina for all your work here. I'm personally really excited for this to land and for us to have a real dev container feature and start using it across all our samples!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I agree with @danieljurek's feedback on the GitHub workflows, but once that's addressed happy to see this land and for us to start using it. Thanks again for all the hard work, everyone :-).
Chatted with Brigit - to add our Dev Container feature to the Remote Containers extension, we'll want to open a PR on |
/check-enforcer override |
Thank you all very much for the great work here. Feel free to let me know if there's any changes. |
This addresses #1095
ext/devcontainer/