Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding devcontainer definition #1118

Merged
merged 25 commits into from
Jul 6, 2023
Merged

Conversation

aaronpowell
Copy link
Contributor

@aaronpowell aaronpowell commented Nov 10, 2022

This addresses #1095

  • Added devcontainer feature definition at ext/devcontainer/
  • Added tests for version
  • Added GitHub Action to generate the devcontainer feature image
  • Added GitHub Action to run tests

ext/devcontainer/README.md Outdated Show resolved Hide resolved
ext/devcontainer/devcontainer-feature.json Outdated Show resolved Hide resolved
ext/devcontainer/devcontainer-feature.json Outdated Show resolved Hide resolved
aaronpowell and others added 2 commits November 24, 2022 09:14
- test jobs need to pass before deploy passes
- deploy job linked to environment for approval
@ghost ghost added the no-recent-activity identity issues with no activity label Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Hi @aaronpowell. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Feb 3, 2023
@ghost
Copy link

ghost commented Feb 3, 2023

Hi @aaronpowell. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@danieljurek danieljurek reopened this Feb 6, 2023
@ghost ghost closed this Feb 13, 2023
@ghost
Copy link

ghost commented Feb 13, 2023

Hi @aaronpowell. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@aaronpowell
Copy link
Contributor Author

/reopen

@ghost ghost reopened this Feb 15, 2023
@ghost ghost removed the no-recent-activity identity issues with no activity label Feb 15, 2023
@vhvb1989
Copy link
Member

@karolz-ms , @jongio ping

Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - One small note about setting the version here to something like 0.1.0 to start with, since we'll want to save 1.0.0 for once we have a little more confidence about these changes.

If @danieljurek is happy with the GitHub action stuff (I think he mentioned at standup today that publishing this from GitHub actions and to the ghcr associated with our repository is right thing to do) I think we can land this.

Thanks @aaronpowell and @hemarina for all your work here. I'm personally really excited for this to land and for us to have a real dev container feature and start using it across all our samples!

ext/devcontainer/src/azd/devcontainer-feature.json Outdated Show resolved Hide resolved
Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I agree with @danieljurek's feedback on the GitHub workflows, but once that's addressed happy to see this land and for us to start using it. Thanks again for all the hard work, everyone :-).

@savannahostrowski
Copy link

Chatted with Brigit - to add our Dev Container feature to the Remote Containers extension, we'll want to open a PR on
https://github.com/devcontainers/devcontainers.github.io/blob/gh-pages/_data/collection-index.yml. This will add it to the list of all community features. https://containers.dev/features

@hemarina
Copy link
Contributor

hemarina commented Jul 6, 2023

/check-enforcer override

@hemarina
Copy link
Contributor

hemarina commented Jul 6, 2023

Thank you all very much for the great work here. Feel free to let me know if there's any changes.

@hemarina hemarina merged commit fa3412e into Azure:main Jul 6, 2023
@aaronpowell aaronpowell deleted the aaronpowell/issue-1095 branch July 6, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants