-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for recorder tests #2414
Conversation
This reverts commit 8991f33.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming along nicely but I'd like to understand more about why we need to perform special case handling for some HTTP requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool - love how little the core of azd
had to change to support this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am wondering if it makes sense for us to put in the effort now to move the recordings out of our tree and into the centralized repo that the other SDK teams use. I think we have the right reasons to be using our own recorder, but it feels like some of the reasons that pushed them to make this change (like the size of the recordings in the repo history over time) might apply to us.
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSIContainer
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Add
recording
package which is a library that allows for recording/playback tests via a HTTP/1.1 proxy server, built on top of go-vcr for serialization of interactions and hooks support.Uptake in tests
Test_CLI_InfraCreateAndDelete
andTest_CLI_InfraCreateAndDeleteUpperCase
.To enable this change, the
azd
binary needs to be compiled withrecord
build tag, which changes the following behaviors:The playback recordings currently persist and roundtrip variables like:
Fixes #1547