Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add devops task to repo #2623

Merged
merged 19 commits into from
Oct 17, 2023
Merged

add devops task to repo #2623

merged 19 commits into from
Oct 17, 2023

Conversation

vhvb1989
Copy link
Member

@vhvb1989 vhvb1989 commented Aug 9, 2023 •
edited
Loading

Adding the Azure Devops extension with the install azd task to the mono-repo.
Adding documentation and test pipeline

danieljurek
danieljurek reviewed Aug 14, 2023
View reviewed changes
Copy link
Member

@danieljurek danieljurek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eng changes LGTM. I have some questions about release. Will sync up offline.

Also a good idea to add to CODEOWNERS

ellismg
ellismg reviewed Aug 29, 2023
View reviewed changes
Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun to see this coming together for all our AzDo customers! A few comments.

ext/azuredevops/package-lock.json Outdated Show resolved Hide resolved
ext/azuredevops/setupAzd/.gitignore Show resolved Hide resolved
ext/azuredevops/setupAzd/package.json Outdated Show resolved Hide resolved
@azure-sdk
Copy link
Collaborator

VSCode Extension Installation Instructions

  1. Download the extension at https://azuresdkreleasepreview.blob.core.windows.net/azd/vscode/pr/2623/azure-dev-0.8.0-alpha.1.vsix
  2. Extract the extension from the compressed file
  3. In vscode
    a. Open "Extensions" (Ctrl+Shift+X)
    b. Click the ...\ menu at top of Extensions sidebar
    c. Click "Install from VSIX"
    d. Select location of downloaded file

@vhvb1989 vhvb1989 requested a review from ellismg October 17, 2023 18:09
weikanglim
weikanglim approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@weikanglim weikanglim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work to have AzDo parity!

wbreza
wbreza approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@wbreza wbreza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - One minor question about how we intent to handle versioning.

ext/azuredevops/setupAzd/task.json Show resolved Hide resolved
@vhvb1989 vhvb1989 merged commit f0915db into Azure:main Oct 17, 2023
9 checks passed
@vhvb1989 vhvb1989 deleted the add-devops-task-to-repo branch October 17, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljurek danieljurek danieljurek left review comments

@hemarina hemarina hemarina approved these changes

@wbreza wbreza wbreza approved these changes

@weikanglim weikanglim weikanglim approved these changes

@karolz-ms karolz-ms Awaiting requested review from karolz-ms karolz-ms is a code owner

@ellismg ellismg Awaiting requested review from ellismg ellismg is a code owner

Assignees

@vhvb1989 vhvb1989

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vhvb1989 @azure-sdk @danieljurek @weikanglim @wbreza @ellismg @hemarina