Remove provision provider initialization from 'up' command #3988
Conversation
There was a problem hiding this comment.
I don't think we can just remove the Initialize().
We need to take some time to review #3745 with PM (due to the UX implications). And also think/explore if there are other side effects (I'm worry about resource-group-deployment)
| @@ -108,19 +88,6 @@ func (u *upAction) Run(ctx context.Context) (*actions.ActionResult, error) { | |||
| } | |||
| defer func() { _ = infra.Cleanup() }() | |||
|
|
|||
| // TODO(weilim): remove this once we have decided if it's okay to not set AZURE_SUBSCRIPTION_ID and AZURE_LOCATION | |||
| // early in the up workflow in #3745 | |||
| err = u.provisioningManager.Initialize(ctx, u.projectConfig.Path, infra.Options) | |||
There was a problem hiding this comment.
IIRC, this was required to support resource group deployments. Azd needs to compile any existing bicep and figure out not only the prompt for parameters, but picking or creating a resource group.
IIRC, we need to break the Initialize method from the provisioning manager in more than one only Initialize method
There was a problem hiding this comment.
Anything that would happen will still happen - just in the provision command. I will test resource group deployments to validate.
|
Hi @wbreza. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
microsoft-github-policy-service
bot
added
the
no-recent-activity
|
Hi @wbreza. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Resolves #3973
Previously we were initializing the provision provider to collect the subscription and location information early within the command.
Since the
upcommand now executes a workflow object - this preemptive initialization causes issues with templates that leveragepreprovisionhooks to set any requiredazdenvironment variables used as defaults of infrastructure parameters causing end users to incorrectly be prompted to supply a value.Pros*
upworkflowCons