hooks: require environment and project always #4011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
wbreza
reviewed
Jul 1, 2024
|
|
||
| stableServices, err := m.importManager.ServiceStable(ctx, projectConfig) | ||
| func (m *HooksMiddleware) registerServiceHooks(ctx context.Context) error { | ||
| stableServices, err := m.importManager.ServiceStable(ctx, m.projectConfig) |
There was a problem hiding this comment.
What happens when there isn't a project? Won't we get a panic for nil reference?
| ) (*actions.ActionResult, error) { | ||
| if projectConfig.Hooks == nil || len(projectConfig.Hooks) == 0 { | ||
| func (m *HooksMiddleware) registerCommandHooks(ctx context.Context, next NextFn) (*actions.ActionResult, error) { | ||
| if m.projectConfig.Hooks == nil || len(m.projectConfig.Hooks) == 0 { |
There was a problem hiding this comment.
Looks like we would get nil reference panic here if projectConfig is nil
Comment on lines
67
to
+74
| hooksRunner := ext.NewHooksRunner( | ||
| hooksManager, | ||
| m.commandRunner, | ||
| envManager, | ||
| m.envManager, | ||
| m.console, | ||
| projectConfig.Path, | ||
| projectConfig.Hooks, | ||
| env, | ||
| m.projectConfig.Path, | ||
| m.projectConfig.Hooks, | ||
| m.env, |
There was a problem hiding this comment.
If the environment isn't available and we have nil for environment I would expect a panic happens here.
|
@wbreza I was thinking this fixes the issue #3920, using the same approach as #3940 where we force environment initialization to happen early-on. The only difference is that in this approach, we don't use middleware to separate initialization into lifecycles. In this PR, we just use the slightly more direct approach of using DI directly. |
|
Hi @weikanglim. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since hooks was introduced, it has always taken a soft dependency on project and environment being available. This change introduces a hard dependency and validates environment and project being available before deciding to register or run hooks.