Updates AKS template to support automatic clusters
#4069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellismg
approved these changes
Jul 10, 2024
templates/common/infra/bicep/core/host/aks-managed-cluster.bicep
Outdated
Show resolved
Hide resolved
templates/common/infra/bicep/core/host/aks-automatic-cluster.bicep
Outdated
Show resolved
Hide resolved
vhvb1989
reviewed
Jul 15, 2024
templates/todo/projects/nodejs-mongo-aks/.repo/bicep/azure.yaml
Outdated
Show resolved
Hide resolved
templates/todo/projects/nodejs-mongo-aks/src/web/manifests/config.tmpl.yaml
Outdated
Show resolved
Hide resolved
templates/todo/projects/nodejs-mongo-aks/src/web/manifests/deployment.tmpl.yaml
Outdated
Show resolved
Hide resolved
|
should fix: #4108 |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: azd-starter-bicepRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/azd-starter-bicep -b pr/4069View Changes | Compare Changes Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/4069View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/4069View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/4069View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/4069View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/4069View Changes | Compare Changes Project: todo-java-postgresql-terraformRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/4069View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/4069View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/4069View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/4069View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/4069View Changes | Compare Changes Project: todo-nodejs-mongo-terraformRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/4069View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/4069View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/4069View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/4069View Changes | Compare Changes Project: todo-python-mongo-terraformRemote: azure-samples-stagingBranch: pr/4069You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/4069View Changes | Compare Changes |
vhvb1989
approved these changes
Jul 15, 2024
|
@v-xuto - We aren't going to merge this in infra/core so we minimize churn there as we phase it out. Can you please make these changes/updates in AVM and update here with links to the issues/prs for it? Thanks |
11 tasks
|
@jongio AVM PR is ready, please review. |
ilhaan
pushed a commit
to Azure/bicep-registry-modules
that referenced
this pull request
Jul 25, 2024
…ervice to support automatic clusters (#2787) ## Description Related to PR: Azure/azure-dev#4069 Adds new automatic setting for container service managed cluster. Set `azure/login@v2` to use federated credential. (Due to some security policies, we are currently unable to use client secret for azure login. After completing all changes to this PR, we will restore the login method. This is currently only for testing the github pipeline.) The failed test in the Pipeline Status Badge has nothing to do with this PR. The specific information can be viewed at: https://github.com/zedy-wj/bicep-registry-modules/actions/runs/10053355723/job/27786049197#step:4:649. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> @jongio for notification. --------- Co-authored-by: zedy <[email protected]>
|
@jongio This PR Azure/bicep-registry-modules#2787 has already been merged, just a reminder for you. |
Closed
11 tasks
2 tasks
ilhaan
pushed a commit
to Azure/bicep-registry-modules
that referenced
this pull request
Oct 25, 2024
](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml){kind=link}
…ervice to support automatic Kubernetes clusters. (#3104) ## Description <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> Related to PR: Azure/azure-dev#4069 AKS automatic requires a new sku name: 'Automatic'. ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | |[](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml)| ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> @jongio, @wbreza for notification. --------- Co-authored-by: zedy <[email protected]> Co-authored-by: Erika Gressi <[email protected]> Co-authored-by: Alexander Sehr <[email protected]>
|](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml/badge.svg?branch=aks%2Fautomatic)](https://github.com/zedy-wj/bicep-registry-modules/actions/workflows/avm.res.container-service.managed-cluster.yml)|){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automaticsetting - when set will use AKS Automatic SKUVITEintegration