passwordless sqlcmd sqlOperation #4140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
ellismg,
wbreza,
hemarina and
weikanglim
as code owners
wbreza
reviewed
Jul 23, 2024
Comment on lines
+285
to
+300
| func downloadSqlCmd( | ||
| ctx context.Context, | ||
| transporter policy.Transporter, | ||
| sqlCmdVersion semver.Version, | ||
| extractImplementation extractSqlCmdCliFromFileImplementation, | ||
| path string) error { | ||
|
|
||
| binaryName := func(platform string) string { | ||
| return fmt.Sprintf("sqlcmd-%s", platform) | ||
| } | ||
|
|
||
| systemArch := runtime.GOARCH | ||
| // arm and x86 not supported (similar to bicep) | ||
| var releaseName string | ||
| switch runtime.GOOS { | ||
| case "windows": |
There was a problem hiding this comment.
All of this custom download/install logic is starting to scare me... azd is not a package manager but instead we should consider leveraging existing package manager like winget or choco to help install missing required components.
I don't think maintaining install/download scripts for various tools is something we want to get into the business of maintaining.
There was a problem hiding this comment.
Talked ofline to Wallace about this.
Maybe we can keep bringing stand-alone binaries to ~/.azd folder if the tool is under Microsoft umbrella. Like gh-cli, bicep-cli, swa-cli, and now sqlcmd-cli.
We definitely don't want to use azd to pull other tools like terraform or something else.
The main idea of using standalone binaries is to have only azd to know about it and be the less invasive to customer's PC. We also don't want to deal with min versions and updates when asking for tools to be installed in the system.
wbreza
reviewed
Jul 23, 2024
wbreza
reviewed
Jul 23, 2024
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
ellismg
reviewed
Aug 9, 2024
| const AzdMetadataTypePrincipalLogin AzdMetadataType = "principalLogin" | ||
| const AzdMetadataTypePrincipalId AzdMetadataType = "principalId" | ||
| const AzdMetadataTypePrincipalType AzdMetadataType = "principalType" | ||
| const AzdMetadataTypeIpAddress AzdMetadataType = "ipAddress" |
There was a problem hiding this comment.
I'm very nervous about this feature (and also the implementation) - Are we totally hosed if we don't have it? I assume this is for us to be able to scope some firewall rules to "the current user's machine" but I am very nervous about corner cases in the implementation with respect to things like NAT.
ellismg
reviewed
Aug 9, 2024
|
|
||
| // GetIpAddress returns the public IP address of the caller. | ||
| func GetIpAddress() (string, error) { | ||
| resp, err := http.Get("https://api.ipify.org") |
There was a problem hiding this comment.
If we must add this, let's figure out a way to do it using an azure backed service (ideally one we don't run!). But this feels like the sort of thing that's going to be a footgun
ellismg
reviewed
Aug 9, 2024
| // sqlCmdCliVersion is the minimum version of sqlCmd cli that we require | ||
| var sqlCmdCliVersion semver.Version = semver.MustParse("1.8.0") | ||
|
|
||
| func NewSqlCmdCli(ctx context.Context, console input.Console, commandRunner exec.CommandRunner) (*SqlCmdCli, error) { |
There was a problem hiding this comment.
NIT: Let's name the exported CLI type, Cli and this method NewCli as we are now doing for the other tools.
microsoft-github-policy-service
bot
added
the
no-recent-activity
|
Hi @vhvb1989. Thank you for your interest in helping to improve the Azure Developer CLI experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @vhvb1989. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 2 features to leverage azd for setting up SQL Server with EntraId Auth.
Based on: https://learn.microsoft.com/en-us/azure/azure-sql/database/authentication-aad-service-principal?view=azuresql
Feature 1) - azd-metadata for bicep input parameters
Feature 2) - sqlScript operation [for azd.operations]