-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Azure Deployment stacks #4165
Conversation
a11a6e5
to
2529c4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wbreza! Added one small comment.
Also, not sure if this is in scope of this PR, but noticed this bug:
b09a59b
to
7d27b30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working my way through this but have some comments I could share now.
I'm wondering if the Stack/StandardDeployments interface is at the right level - it feels like some of the behavior doesn't differ between stack and standard deployments and maybe its simpler if that stuff is not on the interface?
Still working through stack_deployments implementation itself.
4a89a44
to
b3c1259
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another pass and noticed some things but overall looks really good. I was thinking about the issue that Rajesh noticed where this interacts poorly with Aspire since Aspire delays creation of container app resources until deploy
and so they are not part of the deployment stack and hence are not deleted during down
which blocks deletion of the container app environment and hence the stack.
I suspect the answer is we'll have to have down
delete these container apps someway (either manually, or perhaps we modify our deployment logic for aspire to produce one or more deployment stacks for the services.
I wonder if we need a way to control if deployment stacks are on or off at the project level (instead of system wide via the alpha feature). I suspect at some point we'll want to get to a place where I can customize the deployment stack behavior (the deny rules and detach vs delete) in azure.yaml.
b5e46c6
to
936dd0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to get this in and start playing around with deployment stacks!
6de6cf5
to
5da0f28
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Adds support for Azure Deployment stacks within AZD.
provision
supports both subscription & resource group level deployment stacksdown
deletes the deployment stack withDelete
behavior deleting all resource groups/resources that exist within the stackImportant
To enable deployment stacks enable the feature using the following command:
azd config set alpha.deployment.stacks on
Note
Adds 2 implementations of
azapi.DeploymentService
interface:StandardDeployments
- Wrapper around standard ARM deployments APIStackDeployments
- Wrapper around deployment stacks APITODO:
azd down
The following tasks will be resolved for Beta release
Questions
What happens if deployment stacks are enabled after my application is deployed?
A: The deployment will be converted to a deployment stack on next call to
azd provision
. If you attempt to runazd down
the resources will be removed using standard deployments.What happens if deployment stacks are turned off after deployment?
A: Calling
azd down
will fail with errorDeployment not found
.UI (After)
azd provision
azd down
UI (Before)
azd provision
Display of the UI BEFORE this change
azd down
Display of the UI BEFORE this change