Aspire: Use bicep for container app deployment #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plan for Aspire 9 is to support customization of the container app for services by leveraging the CDK to generate the bicep IaC for a given container app. To prepare for that new world, we'd like `azd infra synth` to start writing bicep and to modify our deployment strategy for container apps to be based on ARM deployments instead of directly PUTing a copy of the resource to the RP. This change starts to work through that.
ellismg
force-pushed
the
ellismg/aspire-use-bicep-for-container-deployment
branch
from
f9ce84d
to
b7439bd
Compare
This adds rudimentary support for deploying the `.bicep` version of the IaC for a container app as generated by `azd infra synth`. In the case where both a `.yaml` and `.bicep` version of the IaC for a container app exist, the container `.yaml` version is prefered. When neither the `.yaml` or `.bicep` version of the IaC exist on disk, `azd` will continue to generate and deploy the `.yaml` flavored version of the container app IaC.
This change moves using bicep instead of yaml for container apps for aspire projects behind the alpha flag `aspire.useBicepForContainerApps`. To enable this, run `azd config set alpha.aspire.useBicepForContainerApps on`. Also adds support for using bicep when `infra synth` had not yet been run.
…bicep-for-container-deployment
ellismg
force-pushed
the
ellismg/aspire-use-bicep-for-container-deployment
branch
from
e20da6e
to
125ffbd
Compare
…-use-bicep-for-container-deployment
16 tasks
…-use-bicep-for-container-deployment
|
The main change on the aspire side is in with experimental public APIs to customize this and turn it on. It changes all container and project resources to project.v1 and container.v1 to support this new nested deployment field. |
vhvb1989
requested review from
wbreza,
vhvb1989 and
hemarina
as code owners
…-use-bicep-for-container-deployment
vhvb1989
changed the title
weikanglim
approved these changes
Oct 2, 2024
cli/azd/pkg/apphost/testdata/TestAspireContainerGeneration-main.bicep.snap
Show resolved
Hide resolved
ellismg
commented
Oct 2, 2024
There was a problem hiding this comment.
Thanks for the updates while I was gone, @vhvb1989! I took a look over the changes and went ahead and cleaned some stuff up (mostly removing some of the stuff related to this being behind an alpha flag when I first added it and then no longer needed bicep templates).
Had a few questions about some of the changes but nothing blocking. The one thing I do wonder is if some of the bind mount changes end up changing physical resource names and if so if we want to disallow them, but this looks good.
The .bicepparms file generation is a really smart idea. I wish I had thought of that instead of that weird @metadata thing I was thinking.
…ttps://github.com/ellismg/azure-dev into ellismg/aspire-use-bicep-for-container-deployment
…-use-bicep-for-container-deployment
vhvb1989
approved these changes
Oct 3, 2024
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plan for Aspire 9 is to support customization of the container app for services by leveraging the CDK to generate the bicep IaC for a given container app.
To prepare for that new world, we'd like
azd infra synthto start writing bicep and to modify our deployment strategy for container apps to be based on ARM deployments instead of directly PUTing a copy of the resource to the RP.This change starts to work through that.
This is presently guarded behind an alpha flag, so you'll need to run:
In order to enable this work. When that is turned on,
azdwill generate bicep templates instead of yaml durninginfra synthand also look for bicep files instead of yaml files when doing a deployment.Note - this is a work in progress and complex Aspire features may not be supported yet - but this does work with aspire-starter template. The secure outputs/secrets work is still pretty rough and likely doesn't work, but I'm exploring that next.
fix: #4396